Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100778
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.192.173 cause and error)
MIME-Version: 1.0
In-Reply-To: <25903b1e0fc5a726e44b1e3a5ab4aec4@bohwaz.net>
References: <25903b1e0fc5a726e44b1e3a5ab4aec4@bohwaz.net>
Date: Wed, 27 Sep 2017 09:47:51 +0100
Message-ID: <CA+kxMuQ0p9qwCkxaUFQuR4C_JrPb1RtAguY3su3TvPsiUxOGEw@mail.gmail.com>
To: "BohwaZ/PHP" <php@bohwaz.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Implement SQLite "openBlob" feature
 in PDO
From: danack@basereality.com (Dan Ackroyd)

On 26 September 2017 at 03:03, BohwaZ/PHP <php@bohwaz.net> wrote:
> Kia ora,
>
> https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo


Couple of questions:

> $stream = $pdo->sqliteOpenBlob('test', 'data', 1);

I tried reading the code but failed; what happens when this is called
on a PDO connection that isn't to an SQLite database? Also, there
should probably be tests around that behaviour.

> Proposed PHP Version(s)
> Next PHP 7.x

Please can every RFC be explicit about the version it is aimed at?

Although it might be 'obvious' to you, in the future when someone is
looking back at declined RFCs trying to match up release dates with
RFCs that have 'next' as the version number is confusing.

cheers
Dan
Ack