Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100757
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.175 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <F67262BD-3AAE-46E3-83C5-0E8195D054E4@saxonica.com>
References: <4DE419BB-2630-44B8-B4E7-98E17BEBE749@saxonica.com>
 <CAESVnVrLDnuLy0orY44NFO-GHsYZEvt2RNWT+OwS0F=MCkDkDQ@mail.gmail.com>
 <29B0DEA4-2022-4656-8A61-C3D89DB8D5D2@saxonica.com> <CAESVnVoA6Bdt5EWmooH=q3682Onp7cXLnJKpLk8x3Bfyb0nXCA@mail.gmail.com>
 <F67262BD-3AAE-46E3-83C5-0E8195D054E4@saxonica.com>
Date: Fri, 22 Sep 2017 13:42:48 -0400
Message-ID: <CAESVnVpOnhsCZLoc6hyEbLZ98=xdyvdU0q7wKYE-tTTsUHLkzQ@mail.gmail.com>
To: "O'Neil Delpratt" <oneil@saxonica.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PHP extension - Saxon/C
From: pollita@php.net (Sara Golemon)

>> On Fri, Sep 22, 2017 at 12:21 PM, O'Neil Delpratt <oneil@saxonica.com> w=
rote:
>> I still have the memory leak without that line. I think I was thinking I=
 need to add a refcount to the XdmNode object, but maybe I am wrong.
>>
> The Following gives leak:
>
> $proc =3D Saxon/SaxonProcessor
>
> $xquery =3D $proc->NewXQueryProcessor()
>
> $sourceNode =3D $proc->parseXmlFromString("<foo />=E2=80=9D);
>
> $xquery->setContextItem($sourceNode); // with this line commented out the=
re is no leak.
>
Okay, well the bad news is that assuming the extension you're working
with is the link you gave initially and you did remove the
Z_ADDREF_P() from XQueryProcessor::setContextItem()... I can't point
to why you'd have a memory leak.

-Sara