Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100754
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain saxonica.com from 217.69.43.196 cause and error)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
In-Reply-To: <CAESVnVrLDnuLy0orY44NFO-GHsYZEvt2RNWT+OwS0F=MCkDkDQ@mail.gmail.com>
Date: Fri, 22 Sep 2017 17:21:42 +0100
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <29B0DEA4-2022-4656-8A61-C3D89DB8D5D2@saxonica.com>
References: <4DE419BB-2630-44B8-B4E7-98E17BEBE749@saxonica.com> <CAESVnVrLDnuLy0orY44NFO-GHsYZEvt2RNWT+OwS0F=MCkDkDQ@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Subject: Re: [PHP-DEV] PHP extension - Saxon/C
From: oneil@saxonica.com (O'Neil Delpratt)

I still have the memory leak without that line. I think I was thinking I =
need to add a refcount to the XdmNode object, but maybe I am wrong.


> On 22 Sep 2017, at 17:09, Sara Golemon <pollita@php.net> wrote:
>=20
> On Fri, Sep 22, 2017 at 7:01 AM, O'Neil Delpratt <oneil@saxonica.com> =
wrote:
>>      Z_ADDREF_P(oth);
>>=20
> It's a little rough staring through all the commented out lines and
> inconsistent indenting, but this line stands out to me.
>=20
> Where is oth's refcount meant to be decremented?  Why is it even being
> incremented in the first place?  By having an extra reference, the
> engine doesn't know that it's supposed to clean up the object and free
> its storage.
>=20
> -Sara