Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100753
Return-Path: <php@golemon.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 41985 invoked from network); 22 Sep 2017 16:10:04 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 22 Sep 2017 16:10:04 -0000
Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail
Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.216.170 as permitted sender)
X-PHP-List-Original-Sender: php@golemon.com
X-Host-Fingerprint: 209.85.216.170 mail-qt0-f170.google.com  
Received: from [209.85.216.170] ([209.85.216.170:53720] helo=mail-qt0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id E5/4D-62331-9D535C95 for <internals@lists.php.net>; Fri, 22 Sep 2017 12:10:03 -0400
Received: by mail-qt0-f170.google.com with SMTP id 47so1525824qts.10
        for <internals@lists.php.net>; Fri, 22 Sep 2017 09:10:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=golemon-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc;
        bh=SDpM+e+Yji3dLJzPn8zJh94d47Y9MKrdTe+wwiEeP4E=;
        b=k/ux9EJP1HUxsaTPax6tirhpHGtjaDwWGZDh3BlHCtA4t+Jl8Ln3IkN6Z0yYcbARvy
         V6sg1ZPcN+bjvqZm4Ymi+Fm/Qze9ieirhbId4CmGuybkD66HhlCsapwzIAsNnKZ9S+Zu
         JwvHzJs1x1pkoVEDHag2U7iDBx5WwXTn8eJi2RPdLur1RP2v9t4j6QUu0bfdvtFpmGIY
         oit1MGJ0qh0R2zZklcqw6XY7enHEZiaYc/aEhxEuH52cqKrbM1wl6J+N+LWkEAMwJt+r
         NwPKx4mAS+ESuUoOneLJF5+XIjL6P+7ljz5TtVqva26uagw9+hBzlnMjciYK08v+IqHw
         m+3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
         :date:message-id:subject:to:cc;
        bh=SDpM+e+Yji3dLJzPn8zJh94d47Y9MKrdTe+wwiEeP4E=;
        b=KYbj36W5VI8wly9qZ6EuiYjsKkxYpV42odkq4kjoYEeLM0vKRyBUUqEhoIf323dlrK
         AZ60BZ8ihp9733ODyzlmssj+dAsBmxw+MQSBlQLopv7STiC+Szgg2+FHlPf87Xkn38o6
         o4rmhRF3gDiCk9PoBgHlKVUSf68s4W0l7c2OamhvkOSgl4YsuAVrdnDmF7jYfV/1ItdG
         ZlmINsYYfw6oji09MWp3OGsykef6jMKG07gkVEXRvAUL99Y3yAqptGNzpR01jvRs8wMZ
         1jwKQRKFUDH5vHaSu44ea9RM4w3lyHh4WNfBrJRDZ9dqBdQ/JnKIDy3ubh9ho1C2UTrU
         Tdgg==
X-Gm-Message-State: AHPjjUiFR/FzYD1Uy51jMzRHdqGCDHBWTsH6AUfS/YBzf6R2AzYRI4PW
	vnIJIhLBN5qdeZMBwyG4807JR8uzz5yAcLmXIrN/rw==
X-Google-Smtp-Source: AOwi7QAAplLYoPXL122rxXv4CjmSc7wzLllbmtm1xZ5tSMoRx7XUYgogqb036TeSX1KRRPHVosE3cbDWFCNtAvvm0/w=
X-Received: by 10.200.4.158 with SMTP id s30mr9128734qtg.311.1506096599069;
 Fri, 22 Sep 2017 09:09:59 -0700 (PDT)
MIME-Version: 1.0
Sender: php@golemon.com
Received: by 10.12.132.3 with HTTP; Fri, 22 Sep 2017 09:09:58 -0700 (PDT)
X-Originating-IP: [206.252.215.26]
In-Reply-To: <4DE419BB-2630-44B8-B4E7-98E17BEBE749@saxonica.com>
References: <4DE419BB-2630-44B8-B4E7-98E17BEBE749@saxonica.com>
Date: Fri, 22 Sep 2017 12:09:58 -0400
X-Google-Sender-Auth: 9KtVFmufKU1U74m6npVCv4BS_XQ
Message-ID: <CAESVnVrLDnuLy0orY44NFO-GHsYZEvt2RNWT+OwS0F=MCkDkDQ@mail.gmail.com>
To: "O'Neil Delpratt" <oneil@saxonica.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] PHP extension - Saxon/C
From: pollita@php.net (Sara Golemon)

On Fri, Sep 22, 2017 at 7:01 AM, O'Neil Delpratt <oneil@saxonica.com> wrote:
>       Z_ADDREF_P(oth);
>
It's a little rough staring through all the commented out lines and
inconsistent indenting, but this line stands out to me.

Where is oth's refcount meant to be decremented?  Why is it even being
incremented in the first place?  By having an extra reference, the
engine doesn't know that it's supposed to clean up the object and free
its storage.

-Sara