Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100752 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 38509 invoked from network); 22 Sep 2017 15:06:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Sep 2017 15:06:14 -0000 Authentication-Results: pb1.pair.com header.from=oneil@saxonica.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=oneil@saxonica.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain saxonica.com from 217.69.43.196 cause and error) X-PHP-List-Original-Sender: oneil@saxonica.com X-Host-Fingerprint: 217.69.43.196 UK1MAIL2513-b.mymailbank.co.uk Received: from [217.69.43.196] ([217.69.43.196:60086] helo=uk1mail2513-b.mymailbank.co.uk) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 54/EC-62331-4E625C95 for ; Fri, 22 Sep 2017 11:06:13 -0400 Received: from [192.168.0.11] (cpc81936-leic18-2-0-cust39.8-1.cable.virginm.net [82.6.254.40]) by uk1mail2513-d.mymailbank.co.uk with SMTP; Fri, 22 Sep 2017 16:05:39 +0100 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) In-Reply-To: <1506091241.2415.7.camel@schlueters.de> Date: Fri, 22 Sep 2017 16:06:00 +0100 Cc: PHP internals Content-Transfer-Encoding: quoted-printable Message-ID: <34AFDCF4-B2AF-4DCA-B094-A459A3949138@saxonica.com> References: <4DE419BB-2630-44B8-B4E7-98E17BEBE749@saxonica.com> <1506091241.2415.7.camel@schlueters.de> To: =?utf-8?Q?Johannes_Schl=C3=BCter?= X-Mailer: Apple Mail (2.3124) Subject: Re: [PHP-DEV] PHP extension - Saxon/C From: oneil@saxonica.com (O'Neil Delpratt) > On 22 Sep 2017, at 15:40, Johannes Schl=C3=BCter = wrote: >=20 > On Fr, 2017-09-22 at 12:01 +0100, O'Neil Delpratt wrote: >> =20 >> [Fri Sep 22 08:56:42 2017] Script: '/home/ond1/work/svn/latest9.8- >> saxonc/hec/samples/php/xqueryExamples.php' >> /home/ond1/work/svn/latest9.8- >> saxonc/hec/Saxon.C.API/php7_saxon.cpp(3250) : Freeing=20 > [...] >> See full code of PHP extension: >>=20 >> https://dev.saxonica.com/repos/archive/opensource/latest9.8/hec/Saxon >> .C.API/php7_saxon.cpp >> > n.C.API/php7_saxon.cpp> >=20 > could you point out which line 3250 is? In the linked file line 3250 > refers to this line: I think this is now 3243: xdmNode_object *obj =3D (xdmNode_object *)ecalloc(1, = sizeof(xdmNode_object)+ zend_object_properties_size(type)); Which seems strange to me. >=20 >=20 >=20 > PHP_METHOD(XdmNode, __construct) > { /* <------------------------------------ 3250 */ > php_error(E_WARNING,"XdmNode constructor"); > XdmNode *xdmNode =3D NULL; >=20 >=20 > which makes little sense :-) >=20 Yes indeed. Some left over code which is not doing anything because a = XdmNode can only be created by a utility method on other classes. > johannes >=20