Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100740
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.192.177 cause and error)
MIME-Version: 1.0
In-Reply-To: <7cf5adb8-0738-259e-6d1e-f966722fdae2@gmx.de>
References: <7cf5adb8-0738-259e-6d1e-f966722fdae2@gmx.de>
Date: Thu, 21 Sep 2017 22:08:25 +0100
Message-ID: <CA+kxMuQRHq8HfuicqSFm8_Xcxw7VD6Aaqoi5TZa7m7Tofh1YKA@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] fputcsv() and $escape character
From: danack@basereality.com (Dan Ackroyd)

On 21 September 2017 at 12:43, Christoph M. Becker <cmbecker69@gmx.de> wrote:
> Hi everybody!
>
> There are several bug reports regarding "broken" fputcsv() behavior in
> our tracker, namely, because the $escape parameter causes unexpected
> results.  For instance:


I looked at fixing some of the CSV related bugs about a year or so
ago. My conclusions were:

i) There is no way to fix the problems that wouldn't cause horrible BC
breaks for code that is only coincidentally working currently.

ii) Handling strings in C is much more error prone than handling them in PHP.

I'm reasonably certain that trying to fix the current functions is the
wrong approach, and one of the following would be much better.

Either, find a C library that has already been proven to handle CSV
parsing/generating 'correctly' and bring that into PHP core under
either new function names or namespace.

Or, write the code in PHP (or just use
https://github.com/thephpleague/csv) and find a way to make that fast
enough for people to use.

Touching the existing code is pretty certain to bring a lot of pain,
without resulting in a fully compliant csv parser/generator.

cheers
Dan
Ack