Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100737
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain dqxtech.net from 209.85.215.43 cause and error)
MIME-Version: 1.0
In-Reply-To: <7cf5adb8-0738-259e-6d1e-f966722fdae2@gmx.de>
References: <7cf5adb8-0738-259e-6d1e-f966722fdae2@gmx.de>
Date: Thu, 21 Sep 2017 19:32:57 +0200
Message-ID: <CAH0Uv3FOj_N=XGY+CKiWgp8qqLMFG4fEh-q44t8s5FejOjc3Aw@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] fputcsv() and $escape character
From: andreas@dqxtech.net (Andreas Hennings)

So empty string would enable the standard behavior RFC 7111 with no escape char.
If so, I support this.

I don't know if '' or true / false / null should be this "special value".
It has to be something that was not legal before, and that people
should use intentionally and not by accident.
I guess '' is good enough for this, or not worse than other options.

One question: Does this also require a change in fgetcsv()?
So it can read csv without escape character?
I remember that fgetcsv() does currently tolerate some broken CSV. It
should continue to do so for BC reasons.

For the record, here are some links:
https://stackoverflow.com/questions/44427926/data-gets-garbled-when-writing-to-csv-with-fputcsv-fgetcsv/46342634#46342634
https://bugs.php.net/bug.php?id=74713&edit=2

On Thu, Sep 21, 2017 at 1:43 PM, Christoph M. Becker <cmbecker69@gmx.de> wrote:
> Hi everybody!
>
> There are several bug reports regarding "broken" fputcsv() behavior in
> our tracker, namely, because the $escape parameter causes unexpected
> results.  For instance:
>
>     <?php
>     $row = ['a\\"', 'bbb'];
>
>     $fp = fopen('php://memory', 'w+');
>     fputcsv($fp, $row);
>     rewind($fp);
>     echo stream_get_contents($fp);
>     fclose($fp);
>     ?>
>
> outputs
>
>     "a\"",bbb
>
> instead of the expected
>
>     "a\""",bbb
>
> I don't think the current behavior is a bug, but rather the escape
> character is an extension to the CSV "standard" (RFC 7111).  One can
> practically disable the escape character by passing any character that
> is not contained in any of the strings in the array; "\0" is usually a
> good choice, so changing line 5 in the script above to the following
> gives the desired behavior:
>
>     fputcsv($fp, $row, ',', '"', "\0");
>
> Cf. <https://3v4l.org/InlUv> vs. <https://3v4l.org/tVFBo>.
>
> It is, however, not possible to pass an empty string as $escape
> argument, because fputcsv() bails out in this case raising
>
>   Warning: fputcsv(): escape must be a character
>
> I suggest to allow an empty string instead, and to consider making this
> the default in a future version, probably after some time of deprecating
> any other $escape argument.
>
> Thoughts?
>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>