Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100650
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.48 as permitted sender)
To: ilija.tovilo@me.com, PHP internals <internals@lists.php.net>
References: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark>
Message-ID: <a25a7575-e355-40eb-7977-e55145726085@gmail.com>
Date: Fri, 15 Sep 2017 13:10:36 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Deprecate the extract function in PHP 7.3
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> As a second parameter the `extract` function takes some options to
> make this function less dangerous, like `EXTR_SKIP` that

I'd start with specifying what exactly is "dangerous" in this function.
So far I don't see any specific danger. You can shoot yourself in the
foot, so you can with many other tools in the language.

> I seriously doubt the usefulness of this function, especially looking
> at the potential risks. The fact that overwriting the local variables

Which risks? This function is used by real-life code, and unless you do
something like extract($_GET) in global scope I don't see any problem.
With extract($_GET) we could then also propose to remove all file
functions because fopen($_GET['filename']) or unlink($_GET['filename'])
are also dangerous. But if you use it properly, I don't see what "risks"
are there.

> Any thoughts?

-1 so far, I don't see what problem you are trying to solve.

-- 
Stas Malyshev
smalyshev@gmail.com