Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100648
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain me.com designates 17.172.220.113 as permitted sender)
Content-type: text/plain; charset=utf-8
MIME-version: 1.0 (1.0)
In-reply-to:
 <CAESVnVqi6O7UNmX=jA3nwCLDYXqrPRwZKWYsuoeitjhAX0AGfQ@mail.gmail.com>
Date: Fri, 15 Sep 2017 21:00:24 +0200
Cc: Marco Pivetta <ocramius@gmail.com>, PHP internals <internals@lists.php.net>
Content-transfer-encoding: quoted-printable
Message-ID: <81BBA973-F0B8-4C0F-BFAC-F4FAAD122D5E@me.com>
References: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark>
 <CADyq6sKQ5RqOQvcRK_dSnu+wtHBqwMkoH_Vhxw8NZCi2tk7YPQ@mail.gmail.com>
 <7d703ad8-5596-44e7-95dc-23c2cc058408@Spark>
 <CAESVnVqi6O7UNmX=jA3nwCLDYXqrPRwZKWYsuoeitjhAX0AGfQ@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Subject: Re: [PHP-DEV] [RFC] Deprecate the extract function in PHP 7.3
From: ilija.tovilo@me.com (Ilija Tovilo)

Hi Sara

That is indeed a very good point. Haven't thought of that one.

Regards

> On 15. Sep 2017, at 19:50, Sara Golemon <pollita@php.net> wrote:
>=20
>> On Fri, Sep 15, 2017 at 1:35 PM,  <ilija.tovilo@me.com> wrote:
>> The `extract` function takes an associative array and
>> puts it into the local symbol table.
>> http://php.net/manual/en/function.extract.php
>>=20
>> I seriously doubt the usefulness of this function,
>> especially looking at the potential risks. The fact
>> that overwriting the local variables is the default
>> behaviour doesn=E2=80=99t make it any better. I suggest
>> deprecating it in PHP 7.3 and removing it in 8.
>>=20
> Preface: I despise extract() as well.  It's breaks assumptions for
> both the developer and the runtime.  I save some of my frowniest of
> faces for extract().
>=20
> That said...
>=20
>> I can see it=E2=80=99s usefulness in this case.
>> But wouldn=E2=80=99t it be better to implement this by hand
>> in these rare cases (it=E2=80=99s 3 lines of code) instead of
>> encouraging the pollution of the symbol table by
>> unknown input? It=E2=80=99s also clearer since people who
>> don=E2=80=99t know the `extract` function probably don=E2=80=99t
>> expect it to mutate the local symbol table.
>>=20
> Let's be clear on what that looks like: foreach ($data as $key =3D>
> $value) { $$key =3D $value; }
>=20
> This is SO MUCH WORSE for several reasons, no least of all what
> happens when $data contains keys named 'data', 'key', or 'value'.
>=20
> I'd like to kill extract(), but it does have a reason for being, and I
> couldn't in any good conscience support removing it without a
> replacement that's at least marginally better.
>=20
> -Sara
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20