Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100645
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVqi6O7UNmX=jA3nwCLDYXqrPRwZKWYsuoeitjhAX0AGfQ@mail.gmail.com>
References: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark> <CADyq6sKQ5RqOQvcRK_dSnu+wtHBqwMkoH_Vhxw8NZCi2tk7YPQ@mail.gmail.com>
 <7d703ad8-5596-44e7-95dc-23c2cc058408@Spark> <CAESVnVqi6O7UNmX=jA3nwCLDYXqrPRwZKWYsuoeitjhAX0AGfQ@mail.gmail.com>
Date: Fri, 15 Sep 2017 11:54:19 -0600
Message-ID: <CAObuZdvbh3T7cCoTGYM_G7ZgC3MaTmYkBe9LSieotU6SbukRTQ@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Ilija Tovilo <ilija.tovilo@me.com>, Marco Pivetta <ocramius@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a11352d3218e44405593e15d7"
Subject: Re: [PHP-DEV] [RFC] Deprecate the extract function in PHP 7.3
From: derokorian@gmail.com (Ryan Pallas)

--001a11352d3218e44405593e15d7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 15, 2017 at 11:50 AM, Sara Golemon <pollita@php.net> wrote:

> On Fri, Sep 15, 2017 at 1:35 PM,  <ilija.tovilo@me.com> wrote:
> > The `extract` function takes an associative array and
> > puts it into the local symbol table.
> > http://php.net/manual/en/function.extract.php
> >
> > I seriously doubt the usefulness of this function,
> > especially looking at the potential risks. The fact
> > that overwriting the local variables is the default
> > behaviour doesn=E2=80=99t make it any better. I suggest
> > deprecating it in PHP 7.3 and removing it in 8.
> >
> Preface: I despise extract() as well.  It's breaks assumptions for
> both the developer and the runtime.  I save some of my frowniest of
> faces for extract().
>
> That said...
>
> > I can see it=E2=80=99s usefulness in this case.
> > But wouldn=E2=80=99t it be better to implement this by hand
> > in these rare cases (it=E2=80=99s 3 lines of code) instead of
> > encouraging the pollution of the symbol table by
> > unknown input? It=E2=80=99s also clearer since people who
> > don=E2=80=99t know the `extract` function probably don=E2=80=99t
> > expect it to mutate the local symbol table.
> >
> Let's be clear on what that looks like: foreach ($data as $key =3D>
> $value) { $$key =3D $value; }
>
> This is SO MUCH WORSE for several reasons, no least of all what
> happens when $data contains keys named 'data', 'key', or 'value'.
>

This is a very good point. I hadn't thought about keys being named that
way, but obviously they could! *grumble*


>
> I'd like to kill extract(), but it does have a reason for being, and I
> couldn't in any good conscience support removing it without a
> replacement that's at least marginally better.
>
> -Sara
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a11352d3218e44405593e15d7--