Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100642
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain me.com designates 17.142.194.250 as permitted sender)
Date: Fri, 15 Sep 2017 19:38:22 +0200
To: Ryan Pallas <derokorian@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <ddd6a841-665f-461f-a29f-d9cbf1293927@Spark>
In-reply-to:
 <CAObuZdtSUwyJi-qmg8cDjHJvqGtecTJ8U5J8tm_Oe765m5vDPw@mail.gmail.com>
References: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark>
 <CAObuZdtSUwyJi-qmg8cDjHJvqGtecTJ8U5J8tm_Oe765m5vDPw@mail.gmail.com>
MIME-version: 1.0
Content-type: multipart/alternative; boundary=59bc10dd_643c9869_73e9
Subject: Re: [PHP-DEV] [RFC] Deprecate the extract function in PHP 7.3
From: ilija.tovilo@me.com

--59bc10dd_643c9869_73e9
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi Ryan

I can see your argument. The reasoning behind it is that a function in th=
e standard library should not encourage unsafe code. Admittedly, since th=
is function is rarely used except for templating systems one could call t=
his a non-issue. I just wanted to bring it up.

Regards


On 15 Sep 2017, 19:30 +0200, Ryan Pallas <derokorian=40gmail.com>, wrote:=

>
>
> > On Sep 15, 2017 11:22 AM, <ilija.tovilo=40me.com> wrote:
> > > Hi=21
> > >
> > > The =60extract=60 function takes an associative array and puts it i=
nto the local symbol table.
> > > http://php.net/manual/en/function.extract.php
> > >
> > > =60=60=60
> > > =24array =3D =5B
> > > =C2=A0 =C2=A0 =E2=80=98foo=E2=80=99 =3D> =E2=80=98foo=E2=80=99,
> > > =C2=A0 =C2=A0 =E2=80=98bar=E2=80=99 =3D> =E2=80=98bar=E2=80=99,
> > > =5D;
> > >
> > > extract(=24array);
> > >
> > > print =24foo; // =22foo=22
> > > =60=60=60
> > >
> > > As a second parameter the =60extract=60 function takes some options=
 to make this function less dangerous, like =60EXTR=5FSKIP=60 that preven=
ts an existing local variable of being overwritten. There=E2=80=99s a few=
 more options, go ahead and take a look at the documentation. =60EXTR=5FO=
VERWRITE=60 is the default one though. You can also pass a prefix for the=
 variable names as a third argument.
> > >
> > > I seriously doubt the usefulness of this function, especially looki=
ng at the potential risks. The fact that overwriting the local variables =
is the default behaviour doesn=E2=80=99t make it any better. I suggest de=
precating it in PHP 7.3 and removing it in 8.
> > >
> > > In a whole Symfony-Stack (3.4) with all of it=E2=80=99s dependencie=
s I could only find two usages of this function, both of which could be e=
asily rewritten in vanilla PHP:
> > > https://github.com/symfony/symfony/blob/master/src/Symfony/Componen=
t/Templating/PhpEngine.php=23L148
> > > https://github.com/symfony/symfony/blob/master/src/Symfony/Componen=
t/Templating/PhpEngine.php=23L158
> > >
> > > Only downside: A polyfill is probably impossible since you cannot m=
utate the local symbol table of the callee (as far as I=E2=80=99m aware).=

> > >
> > > Any thoughts=3F
>
> I see no gain by removing this function. I've also seen it used for tem=
plating quite often. Yes the functionality could be changed not to use ex=
tract and end up working the same to the consumer but why make people rew=
rite these things for no apparent gain (and likely a small performance hi=
t)=3F
>
> > >
> > > Regards
> > >
> > >
>

--59bc10dd_643c9869_73e9--