Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100640
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain me.com designates 17.142.194.251 as permitted sender)
Date: Fri, 15 Sep 2017 19:35:57 +0200
To: Marco Pivetta <ocramius@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <7d703ad8-5596-44e7-95dc-23c2cc058408@Spark>
In-reply-to:
 <CADyq6sKQ5RqOQvcRK_dSnu+wtHBqwMkoH_Vhxw8NZCi2tk7YPQ@mail.gmail.com>
References: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark>
 <CADyq6sKQ5RqOQvcRK_dSnu+wtHBqwMkoH_Vhxw8NZCi2tk7YPQ@mail.gmail.com>
MIME-version: 1.0
Content-type: multipart/alternative; boundary=59bc0fb5_327b23c6_73e9
Subject: Re: [PHP-DEV] [RFC] Deprecate the extract function in PHP 7.3
From: ilija.tovilo@me.com

--59bc0fb5_327b23c6_73e9
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi Marco

I can see it=E2=80=99s usefulness in this case.

But wouldn=E2=80=99t it be better to implement this by hand in these rare=
 cases (it=E2=80=99s 3 lines of code) instead of encouraging the pollutio=
n of the symbol table by unknown input=3F It=E2=80=99s also clearer since=
 people who don=E2=80=99t know the =60extract=60 function probably don=E2=
=80=99t expect it to mutate the local symbol table.

Cheers


On 15 Sep 2017, 19:26 +0200, Marco Pivetta <ocramius=40gmail.com>, wrote:=

> Heya,
>
> This is typically used in templating engines.
> The one I worked on is
> https://github.com/zendframework/zend-view/blob/5523511b6771cb6c060a77f=
6777426526a8db5ab/src/Renderer/PhpRenderer.php=23L491-L492
>
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
> On =46ri, Sep 15, 2017 at 7:20 PM, <ilija.tovilo=40me.com> wrote:
>
> > Hi=21
> >
> > The =60extract=60 function takes an associative array and puts it int=
o the
> > local symbol table.
> > http://php.net/manual/en/function.extract.php
> >
> > =60=60=60
> > =24array =3D =5B
> > =E2=80=98foo=E2=80=99 =3D> =E2=80=98foo=E2=80=99,
> > =E2=80=98bar=E2=80=99 =3D> =E2=80=98bar=E2=80=99,
> > =5D;
> >
> > extract(=24array);
> >
> > print =24foo; // =22foo=22
> > =60=60=60
> >
> > As a second parameter the =60extract=60 function takes some options t=
o make
> > this function less dangerous, like =60EXTR=5FSKIP=60 that prevents an=
 existing
> > local variable of being overwritten. There=E2=80=99s a few more optio=
ns, go ahead
> > and take a look at the documentation. =60EXTR=5FOVERWRITE=60 is the d=
efault one
> > though. You can also pass a prefix for the variable names as a third
> > argument.
> >
> > I seriously doubt the usefulness of this function, especially looking=
 at
> > the potential risks. The fact that overwriting the local variables is=
 the
> > default behaviour doesn=E2=80=99t make it any better. I suggest depre=
cating it in
> > PHP 7.3 and removing it in 8.
> >
> > In a whole Symfony-Stack (3.4) with all of it=E2=80=99s dependencies =
I could only
> > find two usages of this function, both of which could be easily rewri=
tten
> > in vanilla PHP:
> > https://github.com/symfony/symfony/blob/master/src/
> > Symfony/Component/Templating/PhpEngine.php=23L148
> > https://github.com/symfony/symfony/blob/master/src/
> > Symfony/Component/Templating/PhpEngine.php=23L158
> >
> > Only downside: A polyfill is probably impossible since you cannot mut=
ate
> > the local symbol table of the callee (as far as I=E2=80=99m aware).
> >
> > Any thoughts=3F
> >
> > Regards
> >
> >
> >

--59bc0fb5_327b23c6_73e9--