Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100638
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark>
References: <097578bf-ab74-44cf-a465-dc6fdd50930f@Spark>
Date: Fri, 15 Sep 2017 19:26:11 +0200
Message-ID: <CADyq6sKQ5RqOQvcRK_dSnu+wtHBqwMkoH_Vhxw8NZCi2tk7YPQ@mail.gmail.com>
To: ilija.tovilo@me.com
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a11442640ad551a05593db1bd"
Subject: Re: [PHP-DEV] [RFC] Deprecate the extract function in PHP 7.3
From: ocramius@gmail.com (Marco Pivetta)

--001a11442640ad551a05593db1bd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Heya,

This is typically used in templating engines.
The one I worked on is
https://github.com/zendframework/zend-view/blob/5523511b6771cb6c060a77f6777=
426526a8db5ab/src/Renderer/PhpRenderer.php#L491-L492


Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On Fri, Sep 15, 2017 at 7:20 PM, <ilija.tovilo@me.com> wrote:

> Hi!
>
> The `extract` function takes an associative array and puts it into the
> local symbol table.
> http://php.net/manual/en/function.extract.php
>
> ```
> $array =3D [
>     =E2=80=98foo=E2=80=99 =3D> =E2=80=98foo=E2=80=99,
>     =E2=80=98bar=E2=80=99 =3D> =E2=80=98bar=E2=80=99,
> ];
>
> extract($array);
>
> print $foo; // "foo"
> ```
>
> As a second parameter the `extract` function takes some options to make
> this function less dangerous, like `EXTR_SKIP` that prevents an existing
> local variable of being overwritten. There=E2=80=99s a few more options, =
go ahead
> and take a look at the documentation. `EXTR_OVERWRITE` is the default one
> though. You can also pass a prefix for the variable names as a third
> argument.
>
> I seriously doubt the usefulness of this function, especially looking at
> the potential risks. The fact that overwriting the local variables is the
> default behaviour doesn=E2=80=99t make it any better. I suggest deprecati=
ng it in
> PHP 7.3 and removing it in 8.
>
> In a whole Symfony-Stack (3.4) with all of it=E2=80=99s dependencies I co=
uld only
> find two usages of this function, both of which could be easily rewritten
> in vanilla PHP:
> https://github.com/symfony/symfony/blob/master/src/
> Symfony/Component/Templating/PhpEngine.php#L148
> https://github.com/symfony/symfony/blob/master/src/
> Symfony/Component/Templating/PhpEngine.php#L158
>
> Only downside: A polyfill is probably impossible since you cannot mutate
> the local symbol table of the callee (as far as I=E2=80=99m aware).
>
> Any thoughts?
>
> Regards
>
>
>

--001a11442640ad551a05593db1bd--