Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100543 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 11173 invoked from network); 12 Sep 2017 15:40:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Sep 2017 15:40:08 -0000 Authentication-Results: pb1.pair.com header.from=come@opensides.be; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=come@opensides.be; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain opensides.be designates 195.154.20.141 as permitted sender) X-PHP-List-Original-Sender: come@opensides.be X-Host-Fingerprint: 195.154.20.141 smtp.argonaut-project.org Received: from [195.154.20.141] ([195.154.20.141:48476] helo=smtp.opensides.be) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 87/D4-10715-4DFF7B95 for ; Tue, 12 Sep 2017 11:40:05 -0400 Received: from localhost (localhost [127.0.0.1]) by smtp.opensides.be (Postfix) with ESMTP id C2816149E8E for ; Tue, 12 Sep 2017 17:40:01 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at opensides.be Received: from smtp.opensides.be ([127.0.0.1]) by localhost (smtp.opensides.be [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7bFpl1UFwtvZ for ; Tue, 12 Sep 2017 17:40:00 +0200 (CEST) Received: from mcmic-probook.localnet (63.120.199.77.rev.sfr.net [77.199.120.63]) by smtp.opensides.be (Postfix) with ESMTPSA id C420D149E88 for ; Tue, 12 Sep 2017 17:40:00 +0200 (CEST) To: "internals@lists.php.net" Date: Tue, 12 Sep 2017 17:39:51 +0200 Message-ID: <6812519.brXpHclNGM@mcmic-probook> Organization: OpenSides User-Agent: KMail/5.2.3 (Linux/4.9.0-3-amd64; KDE/5.28.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Merging LDAP controls support From: come@opensides.be (=?ISO-8859-1?Q?C=F4me?= Chilliet) Hello, I=E2=80=99m getting close to have something I can merge in master for my PR= adding support for LDAP controls: https://github.com/php/php-src/pull/2640 In this case am I suppose to squash the changes in a single commit? This wa= s suggested to me for a previous PR but there is so much changes here I fee= l we should keep the history. If some of you can pull my branch and launch the tests from ext/ldap it wou= ld help. You=E2=80=99ll need an LDAP server and to fill the env vars from e= xt/ldap/tests/connect.inc. C=C3=B4me