Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100522
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.220.169 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <a022f556-c3c1-ea17-5db8-18261f8032e5@gmx.de>
References: <a022f556-c3c1-ea17-5db8-18261f8032e5@gmx.de>
Date: Mon, 11 Sep 2017 10:13:21 -0700
Message-ID: <CAESVnVrWZrB7+9X73p9o0_-L8k+zTgmGsXgmodLsBrBrn_xn_g@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] BCMath and floats
From: pollita@php.net (Sara Golemon)

On Mon, Sep 11, 2017 at 8:36 AM, Christoph M. Becker <cmbecker69@gmx.de> wrote:
> I already have proposed to introduce bcinit() which would take a string,
> int or float, and return a properly formatted string with the given or
> default scale, see <https://github.com/php/php-src/pull/2746>.  Nikita
> suggested to accept the arguments allowed by `bcinit()` for all
> functions in the first place.  This would, however, raise the question
> which scale should be applied to floats.
>
I agree with Nikita.  Given that current behavior for floats passed to
bc*() obey EG(precision), I'd say we should retain that behavior in
these explicit conversions.  That way existing (functional) uses
aren't impacted, we just quietly start working on other cases (where
scientific notation and/or non-period delimiters would have been
used).

> Before proceeding to an RFC (if necessary at all), I'm looking forward
> to hear your thoughts regarding this topic.
>
IMO, this falls under fixing an existing bug (bc*() functions don't
accept certain types of floats), so it wouldn't need an RFC to be
accepted.  I would wait a little bit to get feedback on the scale
question before merging though.  I would even offer that we could
apply this to 7.[012] safely.

-Sara