Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100450 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 68268 invoked from network); 7 Sep 2017 16:51:20 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Sep 2017 16:51:20 -0000 Authentication-Results: pb1.pair.com smtp.mail=rowan.collins@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=rowan.collins@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.45 as permitted sender) X-PHP-List-Original-Sender: rowan.collins@gmail.com X-Host-Fingerprint: 74.125.82.45 mail-wm0-f45.google.com Received: from [74.125.82.45] ([74.125.82.45:36647] helo=mail-wm0-f45.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BF/84-10715-80971B95 for ; Thu, 07 Sep 2017 12:51:20 -0400 Received: by mail-wm0-f45.google.com with SMTP id i189so437132wmf.1 for ; Thu, 07 Sep 2017 09:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:from:message-id; bh=SOl0bu32zdM/hk3otaztjwxHjomF1Nz0tk9J06W2NhY=; b=UUjQSOtzb2GGD2OmW7UjkVwaRuGLbJZ1WbW/ENcjhHIOySQPkkXw2zDigoiSf6oGMz PLpCQwxgh8ydUIhA5yD0tWL2ulCWVrRdGshViiIr/D6M65Jwnb0u+J5CPbZT9pRmmwrc 2zn0qXbofgr72ocWQq4JGrBOqF8Zu1b7mACFoIwjspTmFSJ7/1dOk8bPyDUh+xTriNl8 SRbBs2Iiw44jWX3RAFzTrPbMB0rVLUwwCeJc1haK06O0Y2HUVgrDeC7P+YsHSgy6zoCz BrPQKu0RA+zuoiMhWbITPrChDO5dGNxVgW4Z/MF1DxCm/jO7FDDw5x3Yu9+ATEOR2e5E JX8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:subject:to:from:message-id; bh=SOl0bu32zdM/hk3otaztjwxHjomF1Nz0tk9J06W2NhY=; b=WJ0qSNYHcrLX9Ce1kPs9XWpwcG2Xx+Rsyf1snuItE6gNJWTPjaUnm76SOG3WP9qs2n l09J2gWzMu1RngSsrc69Iak5egOXjhZp+wTeP07oa7jEhuA4Ze0ji478UUzlup8RwHmO b141qHTAOhZfXG52i7obrrOpRu2NunIGNUgrGXilYN29SEl4xAGoAofKcEjxHXRElBR2 mTBoklLYPofWmmc6ayqX3sWiwQ1A4cOFz1Qvm8f6bcfu7F11i1KcPviW85qvBM+b+6wa Yn9izyhYuh26w0ouwdu6S+7Tev3R/r6pA1WJDgpFacTt6GHBTdq1FXvfjt7Ch3nLdBPB Y0dQ== X-Gm-Message-State: AHPjjUjhWU45kmlTwCTe3TqeTVQTlL0vofzbWn/fi7aF70rGL99ANt7/ +Zd8Rhf95hQk3gsWsB0= X-Google-Smtp-Source: ADKCNb7OuL2X2PGvvX1cXUr6k04xfbb/28YOwyo3zkVPZl1r+tZawVoK1QQE7ItFceM6kYOuJ3x8Kg== X-Received: by 10.80.226.139 with SMTP id p11mr3024022edl.207.1504803077615; Thu, 07 Sep 2017 09:51:17 -0700 (PDT) Received: from [10.61.116.69] (188.29.164.112.threembb.co.uk. [188.29.164.112]) by smtp.gmail.com with ESMTPSA id g31sm53931edc.44.2017.09.07.09.51.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Sep 2017 09:51:16 -0700 (PDT) Date: Thu, 07 Sep 2017 17:51:14 +0100 User-Agent: K-9 Mail for Android In-Reply-To: References: <8C.6B.10715.4A4A0B95@pb1.pair.com> <89.E2.10715.84651B95@pb1.pair.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: internals@lists.php.net Message-ID: <2855BF93-08E2-4864-89D0-B999845C6BB0@gmail.com> Subject: Re: [PHP-DEV] Consider only ignoring newlines for final ?> in a file From: rowan.collins@gmail.com (Rowan Collins) On 7 September 2017 16:34:38 BST, Michael Morris wro= te: > Suppose someone creates a template >wrapper with this circumstance in mind=2E Instead of doing the obvious, >omit >the final ?> tag in the template, they write code in the template >wrapper >to snip the last endline character from the included file=2E Depending on >how >their code is written your change could now become a breaking change: >for >example they just lop off the last character of the template's return >without checking to see if it is indeed a newline character=2E I think you have the change the wrong way round (unless I do)=2E The curre= nt behaviour is: - PHP blocks at end of file -> suppress following newline - PHP blocks elsewhere in file -> suppress following newline The proposed behaviour is: - PHP blocks at end of file -> suppress following newline (no change) - PHP blocks elsewhere in file -> treat following newline literally So in your scenario, there would be no newline to trim, before or after th= e proposed change=2E Regards, --=20 Rowan Collins [IMSoP]