Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100449
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <89.E2.10715.84651B95@pb1.pair.com>
References: <8C.6B.10715.4A4A0B95@pb1.pair.com> <CAEUnE0dhbacb=5o-9Gf6xKYGkJiiPUCMp2_dZq0iWf+jaXq-Sg@mail.gmail.com>
 <89.E2.10715.84651B95@pb1.pair.com>
Date: Thu, 7 Sep 2017 11:34:38 -0400
Message-ID: <CAEUnE0catL86x9XX8AZPGgF=zu+R6FAuY2eczZEFPj508=Z1Pw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a1148add6d1cb9f05589b3220"
Subject: Re: [PHP-DEV] Consider only ignoring newlines for final ?> in a file
From: tendoaki@gmail.com (Michael Morris)

--001a1148add6d1cb9f05589b3220
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 7, 2017 at 10:23 AM, Andrea Faulds <ajf@ajf.me> wrote:

> What I want to change is how it behaves in other circumstances, i.e.
> templating.
>
> Thanks.
>
>
I get that, but I can think of one example where this innocent change might
BC break something.  You cite this change being for templating - this
implies the php files with this feature are being loaded by another php
file with require() or include(). Suppose someone creates a template
wrapper with this circumstance in mind. Instead of doing the obvious, omit
the final ?> tag in the template, they write code in the template wrapper
to snip the last endline character from the included file. Depending on how
their code is written your change could now become a breaking change: for
example they just lop off the last character of the template's return
without checking to see if it is indeed a newline character.

--001a1148add6d1cb9f05589b3220--