Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100429
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+kxMuSuB7xcMYXcsVj4NDZKwBZWq3sbt2h6s9J4QxzOcfCTHg@mail.gmail.com>
References: <CAGa2bXafM0QgMdCuUfEnNcejHAi208=4tCqbi1APT20Z_jcvuQ@mail.gmail.com>
 <EDA8C042-02B5-4DF9-9D15-176B1DE6587B@gmail.com> <CAGU04m+RtKkPkmzCzFjHvT=pHE9_tVzWuSd6umk2P1U-g8wy_Q@mail.gmail.com>
 <CADyq6s+QpHB2iPb=T=M2NL1aUTS=Uuf07WpQR5j26kFKDCxzpg@mail.gmail.com>
 <0C7F986C-B0BC-4315-98ED-B4FD003B9399@gmail.com> <CAGa2bXa-6kN1yEbnVzbReLX3qH2gVJ5LTmfR31jOp_GwASbrrA@mail.gmail.com>
 <e14c1e6f-4677-6a87-ef30-e3e627c26270@lsces.co.uk> <c08cbbf5-fb27-7c50-3bcc-c89ccfbd6202@rhsoft.net>
 <2a4491b4-e6f5-4297-beec-363f373a93e6@lsces.co.uk> <3f8be7b1-0e59-21c6-4fe8-8299b2c05645@rhsoft.net>
 <6ba62d62-f1ab-9e7b-93f0-a1a9238c47a6@lsces.co.uk> <CAGa2bXYch8UJ70No=UvqtQ79pKbJ1MRtHN0QLk8kCSV+yhMNbg@mail.gmail.com>
 <f8959d0a-429f-4efc-8682-572680a075fa@lsces.co.uk> <E83D7E80-5DC8-49AC-9FA6-D6C1A42ADAE7@gmail.com>
 <0db9cfa3-2b31-ee41-713c-889b7cc06406@lsces.co.uk> <E9DCBF61-8B3D-41C3-9D09-61C6CC8810F3@gmail.com>
 <CA+kxMuSuB7xcMYXcsVj4NDZKwBZWq3sbt2h6s9J4QxzOcfCTHg@mail.gmail.com>
Date: Thu, 7 Sep 2017 13:26:26 +0900
Message-ID: <CAGa2bXZVQPtYi2-MeOmAHXFSwa84ipkAbA7UTYphwhfNjw8QzA@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Cc: Rowan Collins <rowan.collins@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a113fb3288f5891055891df78"
Subject: Re: [PHP-DEV] A validator module for PHP7
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a113fb3288f5891055891df78
Content-Type: text/plain; charset="UTF-8"

Hi Dan


On Wed, Sep 6, 2017 at 8:38 PM, Dan Ackroyd <danack@basereality.com> wrote:

> On 6 September 2017 at 12:15, Rowan Collins <rowan.collins@gmail.com>
> wrote:
>
> > If you have suggestions for how the format should look
>
> Don't use a format. Just write code - see below.
>
> > Which is why Yasuo and I have both suggested we work together
>
> If you're going to work together and continue the conversation, please
> can you move this conversation elsewhere?
>
> It doesn't appear to be actually anything to do with PHP internals.
>
> On 4 September 2017 at 07:33, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> >
> > Since I didn't get much feedbacks during the RFC discussion, I cannot
> tell
> > what part is disliked.
>
> Yes you did. You got feedback during the discussion and also during
> the vote. For example: http://news.php.net/php.internals/95164
>
> However you continually choose to ignore that feedback.
>
> I will attempt once more, to get the main point through to you.
> Perhaps a small amount of repetition, will get it through:
>
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
> This type of library should be done in PHP, not in C.
>
> cheers
> Dan
> Ack
>
>
> function validateOrderAmount($value) : int {
>     $count = preg_match("/[^0-9]*/", $value);
>
>     if ($count) {
>         throw new InvalidOrderAmount("The order value must contain
> only digits.");
>     }
>
>     $value = intval($value);
>
>     if ($value < 1) {
>         throw new InvalidOrderAmount("The order value must be one or
> more.");
>     }
>
>     if ($value >= MAX_ORDER_AMOUNT) {
>         throw new InvalidOrderAmount(
>         "Order value to big. Maximum allowed value is ".MAX_ORDER_AMOUNT
>         );
>     }
>
>     return $value;
> }
>


You seems mixing up responsibility between
 - Input validation that should be input handling code's responsibility.
 - Logical validation that should be model code's responsibility .

Please stick to single responsibility principle that you should be well
aware of.
Input handling code should only accepts valid inputs and let other codes
use it.
Other responsibilities are not input handling code's responsibilities.

Your example code should be in logic, not input handling, that is written
by PHP script.

As I wrote in README.md, there are only 3 types of inputs.

 1. Valid data should accepted.
 2. Valid data should accepted, but user's mistake. e.g. Logical error like
your example above.
 3. Invalid. Anything other than 1 and 2 (i.e. Client cannot send these
value)

"validate" module is supposed to take care 3 which is nothing to do with
models, etc.
It should validate against input data spec, not logical meaning of the
input. If
programmer did this, single responsibility principle is broken.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a113fb3288f5891055891df78--