Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100409
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.192.180 cause and error)
MIME-Version: 1.0
In-Reply-To: <E9DCBF61-8B3D-41C3-9D09-61C6CC8810F3@gmail.com>
References: <CAGa2bXafM0QgMdCuUfEnNcejHAi208=4tCqbi1APT20Z_jcvuQ@mail.gmail.com>
 <EDA8C042-02B5-4DF9-9D15-176B1DE6587B@gmail.com> <CAGU04m+RtKkPkmzCzFjHvT=pHE9_tVzWuSd6umk2P1U-g8wy_Q@mail.gmail.com>
 <CADyq6s+QpHB2iPb=T=M2NL1aUTS=Uuf07WpQR5j26kFKDCxzpg@mail.gmail.com>
 <0C7F986C-B0BC-4315-98ED-B4FD003B9399@gmail.com> <CAGa2bXa-6kN1yEbnVzbReLX3qH2gVJ5LTmfR31jOp_GwASbrrA@mail.gmail.com>
 <e14c1e6f-4677-6a87-ef30-e3e627c26270@lsces.co.uk> <c08cbbf5-fb27-7c50-3bcc-c89ccfbd6202@rhsoft.net>
 <2a4491b4-e6f5-4297-beec-363f373a93e6@lsces.co.uk> <3f8be7b1-0e59-21c6-4fe8-8299b2c05645@rhsoft.net>
 <6ba62d62-f1ab-9e7b-93f0-a1a9238c47a6@lsces.co.uk> <CAGa2bXYch8UJ70No=UvqtQ79pKbJ1MRtHN0QLk8kCSV+yhMNbg@mail.gmail.com>
 <f8959d0a-429f-4efc-8682-572680a075fa@lsces.co.uk> <E83D7E80-5DC8-49AC-9FA6-D6C1A42ADAE7@gmail.com>
 <0db9cfa3-2b31-ee41-713c-889b7cc06406@lsces.co.uk> <E9DCBF61-8B3D-41C3-9D09-61C6CC8810F3@gmail.com>
Date: Wed, 6 Sep 2017 12:38:03 +0100
Message-ID: <CA+kxMuSuB7xcMYXcsVj4NDZKwBZWq3sbt2h6s9J4QxzOcfCTHg@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] A validator module for PHP7
From: danack@basereality.com (Dan Ackroyd)

On 6 September 2017 at 12:15, Rowan Collins <rowan.collins@gmail.com> wrote:

> If you have suggestions for how the format should look

Don't use a format. Just write code - see below.

> Which is why Yasuo and I have both suggested we work together

If you're going to work together and continue the conversation, please
can you move this conversation elsewhere?

It doesn't appear to be actually anything to do with PHP internals.

On 4 September 2017 at 07:33, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
> Since I didn't get much feedbacks during the RFC discussion, I cannot tell
> what part is disliked.

Yes you did. You got feedback during the discussion and also during
the vote. For example: http://news.php.net/php.internals/95164

However you continually choose to ignore that feedback.

I will attempt once more, to get the main point through to you.
Perhaps a small amount of repetition, will get it through:

This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.
This type of library should be done in PHP, not in C.

cheers
Dan
Ack


function validateOrderAmount($value) : int {
    $count = preg_match("/[^0-9]*/", $value);

    if ($count) {
        throw new InvalidOrderAmount("The order value must contain
only digits.");
    }

    $value = intval($value);

    if ($value < 1) {
        throw new InvalidOrderAmount("The order value must be one or more.");
    }

    if ($value >= MAX_ORDER_AMOUNT) {
        throw new InvalidOrderAmount(
        "Order value to big. Maximum allowed value is ".MAX_ORDER_AMOUNT
        );
    }

    return $value;
}

(i'd probably recommend not using exceptions, but instead return
[$valid, $value] to allow validating multiple items without having to
use exceptions for flow control.)