Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100387
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain heigl.org designates 195.191.240.18 as permitted sender)
To: internals@lists.php.net, Fleshgrinder <php@fleshgrinder.com>
References: <b92961d5-a34f-737b-896b-0d63da0f7f6b@fleshgrinder.com>
Openpgp: id=967CCFA50DFFEE03BB8BF5F2CA9213C75BFCE472
Message-ID: <b0f45799-94c6-3676-82ec-8667d8933211@heigl.org>
Date: Tue, 5 Sep 2017 19:01:36 +0200
MIME-Version: 1.0
In-Reply-To: <b92961d5-a34f-737b-896b-0d63da0f7f6b@fleshgrinder.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="lEqj0LdiFIJKW7397KSNLmT9rGkHkOe4M"
Subject: Re: [PHP-DEV] [VOTE] UUID
From: andreas@heigl.org (Andreas Heigl)

--lEqj0LdiFIJKW7397KSNLmT9rGkHkOe4M
Content-Type: multipart/mixed; boundary="MOV1H9I7oFwcWjbkTtGtqULgNsLKucGGx";
 protected-headers="v1"
From: Andreas Heigl <andreas@heigl.org>
To: internals@lists.php.net, Fleshgrinder <php@fleshgrinder.com>
Message-ID: <b0f45799-94c6-3676-82ec-8667d8933211@heigl.org>
Subject: Re: [PHP-DEV] [VOTE] UUID
References: <b92961d5-a34f-737b-896b-0d63da0f7f6b@fleshgrinder.com>
In-Reply-To: <b92961d5-a34f-737b-896b-0d63da0f7f6b@fleshgrinder.com>

--MOV1H9I7oFwcWjbkTtGtqULgNsLKucGGx
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Am 02.09.17 um 09:01 schrieb Fleshgrinder:
> Hello Internals!
>=20
> I just started the voting for the inclusion of a UUID value object in
> PHP's core, targeting PHP 7.3. I wanted to start earlier, but was sick
> the whole week.
>=20
> The voting is open starting now and until September 16. (2 weeks).
>=20
Hey Richard, Hey all.

Thanks for putting up the RFC and the implementation!

Having UUIDs in the core would be awesome. One of the reasons would be
that it's in C. That'd be faster but would also allow easier integration
with system-calls to be easier able to get the MAC-Address for a type-1
UUID f.e.

But why limit UUIDs to type 3 through 5? Having security in mind is good
IMHO but not implementing type 1 and 2 limits the usability and
therefore the usefullness. Let the users decide whether they need it or
not. As long as people can create SQL-Injections in PHP we should not
use the security argument to limit usability or not implement
standardized functionality.

Especially when there is a full-fledged reference-implementation in
userland available. In the RFC you reference ramsey/uuid yourself. But
why should one use the internal UUID-class/functionality when there is a
more powerful one in userland available?

And limiting the usability and extendability of the UUID-Class itself by
declaring it final means that userland-code can only wrap the class but
not extend it. So userland code can not typehint for the UUID-class when
special features are necessary that would need extending the class. And
as there's no interface, I can't typehint for that either.

So all in all for me that's

* less functionality than the reference-implementation
* missing UUID-types (the ones that are easier to implement in C)
* missing extendability

and a naging feeling that the imlementation decides what I as a user
actually need.

That's why I can't vote "yes".

Sorry.

Thanks for putting in the effort and coming up with a first implementatio=
n.

Cheers

Andreas

PS: Personally I don't like a "uuid_4_create" as that would also mean
there should be a "uuid_1_create" through "uuid_5_create" as well and
then there also would need to be a "uuid_1_verify" through "uuid_5_verify=
"=E2=80=A6

--=20
                                                              ,,,
                                                             (o o)
+---------------------------------------------------------ooO-(_)-Ooo-+
| Andreas Heigl                                                       |
| mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E 08=C2=B0=
23'58" |
| http://andreas.heigl.org                       http://hei.gl/wiFKy7 |
+---------------------------------------------------------------------+
| http://hei.gl/root-ca                                               |
+---------------------------------------------------------------------+


--MOV1H9I7oFwcWjbkTtGtqULgNsLKucGGx--

--lEqj0LdiFIJKW7397KSNLmT9rGkHkOe4M
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEENHMr85T+FLwCJRBgjNqPc6i4Q/AFAlmu2HAACgkQjNqPc6i4
Q/Akww/9GZ2VNFznkejqc2dEyo+ogR578pKKPp8gRYM1tOEXz6sojsOVWstP8rHy
RGL2qBal2jZpG+3Y6PndKri5S3+ks1fr77icKkm3MzHUlA6mSS+Cz1w5zZPrVPCm
3yQqBvz6lqsK/QWmfg/Ank4ph6xRN5yyx7KHVHyqq210v5hop38xq0YnBDfTS1I2
KuQwW/tGYSwJ6a5pw/h5NpzFjKkn3wtYFgzwpAY8PNpmTcwo6dKCNsmn/9k4BlUz
bf7jmkOEC5Kv70uCBksZ/Q5W24GUevstys94dnQBZH7Vg65fPof3WF0hDZDLl4JR
NVA8Q/jKs/aRbhbFwpGDCUqXEotRRWxh/VYNl29H8k7elFN79iqcd4Bx405rr19K
/kZEZGIE8FRaLf+Cojlz1eR47e3cxCMY2rKjQOr+on8hOzfg4Jn3XJ7EdtZQgoZX
DqtpXxEjn0Ay5iRGFJSpm88hGgzijiRWvC7qD07wltddnaSfFqi32dOMjOi7G2Bs
uW5FnERwOkp6ICBD2dpmdGy1X1orVXXhDI9+O/XWplUH5hbpATS/jKZPamuRjOkC
JyraqUFWWeU3qiX1g1UgD0ryOVihLXENwGYVmr3rzSGTWD0EBZZ7khidWYfaoXfk
W7sGhTRZkMQrvQQ4eAPZxO8EwlKPiCmPQlZV5lwu2NH4s5yos/k=
=jrmX
-----END PGP SIGNATURE-----

--lEqj0LdiFIJKW7397KSNLmT9rGkHkOe4M--