Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100373
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 74.125.83.43 cause and error)
MIME-Version: 1.0
In-Reply-To: <4CFF3E6E-5B9B-49CE-9603-33170CD63421@gmail.com>
References: <CA+kxMuT+MBX1e71y9i3Kfn0cCAWG8+iPW=TY1VA532q6Jkg=LA@mail.gmail.com>
 <4CFF3E6E-5B9B-49CE-9603-33170CD63421@gmail.com>
Date: Mon, 4 Sep 2017 21:05:12 +0100
Message-ID: <CA+kxMuRJotfwhxMA1g+SccQ=x7XL-JfC5MXjphJGT8sSBUyKqg@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC][Discussion] Consistent callables
From: danack@basereality.com (Dan Ackroyd)

Stephen Reay wrote:
> Regarding the big change you suggest, making protected/private methods return false unless a new third parameter is true in is_callable():
> I think you need to make your intention a *lot* clearer

On 29 May 2017 at 12:01, Rowan Collins <rowan.collins@gmail.com> wrote:
> Regarding is_callable, ....could lead to some very confusing bugs. IMO, when BC breaks are necessary, they should be big and obvious so people spot and fix them.


Most of the feedback I got was how modifying the existing is_callable
function was dumb, so I've updated the RFC, and dropped the idea of
modifying the existing is_callable function.

That function will stay as it is, and will be used to determine if a
variable can be called in the current scope, through either direct
invocation or call_user_func().

The RFC instead now proposes a separate function of is_callable_type,
to determine if a variable can be used as callable in all scopes, and
so will pass the callable type check for parameters and return types.

cheers
Dan
Ack