Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100368
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.50 as permitted sender)
Date: Mon, 04 Sep 2017 13:53:14 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <CAGa2bXafM0QgMdCuUfEnNcejHAi208=4tCqbi1APT20Z_jcvuQ@mail.gmail.com>
References: <CAGa2bXafM0QgMdCuUfEnNcejHAi208=4tCqbi1APT20Z_jcvuQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: internals@lists.php.net,Yasuo Ohgaki <yohgaki@ohgaki.net>,"internals@lists.php.net" <internals@lists.php.net>
Message-ID: <EDA8C042-02B5-4DF9-9D15-176B1DE6587B@gmail.com>
Subject: Re: [PHP-DEV] A validator module for PHP7
From: rowan.collins@gmail.com (Rowan Collins)

On 4 September 2017 07:33:41 BST, Yasuo Ohgaki <yohgaki@ohgaki=2Enet> wrote=
:
>Hi all,
>
>I spent a little time for a new input validation module=2E It's not
>totally
>new module, but is based on Filter module's validation filter
>improvement
>RFC in many ways=2E [1]

Hi Yasuo,

Thanks for tackling this=2E I do think the current filter module is user u=
nfriendly and it would be great to have something better=2E A couple of qui=
ck thoughts based on your README:

- The use of nested arrays keeps things simple in one sense, but the deep =
nesting can get confusing=2E I wonder if a ValidationRule class would make =
the distinction between parameters and references to existing rules clearer=
=2E This would also give you a natural home for validating the validation r=
ules themselves (probably by throwing an exception in the constructor)=2E

- A minor point, but most style guides would suggest function names should=
 be verbs, not adjectives, so "validate()" rather than "valid()"=2E

- Is there a use case for valid_id() or is it a temporary debugging thing =
that won't be in the final version?

In general, I like the idea, but would have to play around a bit to see if=
 it felt easy to use in real world situations=2E

Regards,

--=20
Rowan Collins
[IMSoP]