Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100322
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain genkgo.nl designates 46.21.156.38 as permitted sender)
To: Stanislav Malyshev <smalyshev@gmail.com>, internals@lists.php.net
References: <a4189866-23ea-4dc5-12a4-a7fbad8e5601@genkgo.nl>
 <1abd260d-ebc4-a062-3381-72485946e8bc@gmail.com>
Message-ID: <a55b37e3-268c-f8ab-6545-6cf7a4f537f0@genkgo.nl>
Date: Mon, 28 Aug 2017 21:53:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1abd260d-ebc4-a062-3381-72485946e8bc@gmail.com>
Content-Type: multipart/alternative;
 boundary="------------5A3B7DD2333FCF61B0F29A2E"
Content-Language: en-US
Subject: Re: [PHP-DEV] [VOTE] Same Site Cookie RFC
From: f.bosch@genkgo.nl (Frederik Bosch)

--------------5A3B7DD2333FCF61B0F29A2E
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Stanislav,

My reasoning for this is as follows.

1. The session_set_cookie_params function requires a lifetime parameter 
at the moment.

2. To enforce that lifetime stays required I did not want to make it 
required within the optional array. That would make that optional array 
not optional anymore, and even have a required key. I don't think that 
is a good idea.

3. To prevent that the array of options is different between the three 
functions (session_set_cookie_params, setcookie, setrawcookie), I chose 
to exclude lifetime from the array of options and include it in the list 
of arguments.

Hence, I chose a consistent and logical API over the three functions 
together rather than having logical ones per function. Hope it makes sense.

Best,
Frederik




On 28-08-17 21:06, Stanislav Malyshev wrote:
> Hi!
>
>> additional argument to these three functions. The second implementation
>> suggestion is to allow an array of options in which all the cookie
>> options will be moved into. More details are to be found in the RFC.
> Something not clear to me on the second one - why lifetime/expiration is
> a separate parameter while all others are part of $options?
>


--------------5A3B7DD2333FCF61B0F29A2E--