Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100287
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <61a5739f15f3a645fd9406fa44fa3f59@bohwaz.net>
References: <1e398f12adbdbed6b7caf3b0af07f284@bohwaz.net> <CADxrgCOVu8+91THShrpGLvzqRKBr7URm69s792K2Ufi=GxoTSw@mail.gmail.com>
 <069c08bfe15b856007debab5d0d961be@bohwaz.net> <CADyq6sKDTp02dk816_2pqaFFRa5kEwXa=8AcjsD=UhZ7dgSmHw@mail.gmail.com>
 <e52aa112ca7aa2fa041a40b5eb2dc729@bohwaz.net> <CADyq6sKFgAy7M=wN+2YxHmcHh5pYrgEgkueR4EDYN+2Pt1GZTg@mail.gmail.com>
 <7b50581b7b2b96920867de76f75c0dfd@bohwaz.net> <CADyq6sKMZSSeFsqGJO8eEZks8XPTtFwkA1+D2kx6EQ-dGOQ17A@mail.gmail.com>
 <61a5739f15f3a645fd9406fa44fa3f59@bohwaz.net>
Date: Wed, 23 Aug 2017 07:20:04 +0200
Message-ID: <CADyq6sLvXVx4KY=NNEAs5=WJ1AxBF=JhOhcGvQGEt-_ZUfMdqA@mail.gmail.com>
To: "BohwaZ/PHP" <php@bohwaz.net>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c19339e60e4af055764ddb3"
Subject: Re: [PHP-DEV] Matching PDO_SQLite features with SQLite3 extension
From: ocramius@gmail.com (Marco Pivetta)

--94eb2c19339e60e4af055764ddb3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

PDO\sqlite_open_blob($pdo, ...).

And no, just because a lot of folks jumped from the bridge doesn't make
jumping from the bridge acceptable. You can pursue the approach, but you
will get a negative vote from over here: that's also where my influence
stops though.

On 23 Aug 2017 7:15 AM, "BohwaZ/PHP" <php@bohwaz.net> wrote:

> Le 23/08/2017 16:57, Marco Pivetta a =C3=A9crit :
>
>> I suggest adding dedicated functions that given a PDO instance and the
>> parameters you needed do what you want to do.
>>
>
> So if I understand correctly:
>
> $pdo =3D new PDO('sqlite::memory:');
> $extended =3D new PDO_Extended_SQLite($pdo);
> $blob =3D $extended->openBlob(...);
>
> That's kinda better, but that doesn't solve much, as that means that only
> one method will be in this new class, and PDO will still have
> sqliteCreate... methods
>  as we won't cause unnecessary BC breaks.
>
> I'm not a C developer though and I don't see how that would be possible.
>
> My feeling is that it would have been better to have a class extending PD=
O
> for each driver, adding additional constants and methods, but that's not
> how PDO has been designed, and I'm not gonna suggest that we should rewri=
te
> PDO now.
>
> And yes, you are adding new stuff: php-src has this widespread
>> misunderstanding that "reproducing new lower layer behaviour in upper
>> layers" should happen no matter what.
>>
>
> I don't get your point, this is already in a upper layer no? PDO already
> has that for SQLite and I just checked and pgSQL too:
>
> PDO::pgsqlCopyFromArray
> PDO::pgsqlCopyFromFile
> PDO::pgsqlCopyToArray
> PDO::pgsqlCopyToFile
> PDO::pgsqlGetNotify
> PDO::pgsqlGetPid
> PDO::pgsqlLOBCreate
> PDO::pgsqlLOBOpen
> PDO::pgsqlLOBUnlink
>
> I'm not gonna create another way of having driver-specific features that
> wouldn't make sense in relation to existing methods, and I don't have tim=
e
> to rewrite a significant part of PDO that would cause a major BC-break.
>
> We all agree that this is not the best way, but it's too late for that I
> think.
>
> So can we go back to topic?
>
> I'm just trying to improve existing PHP in the (very little amount of)
> free time that I've got, following what has already been done, not trying
> to refactor/reinvent/do major changes stuff here.
>

--94eb2c19339e60e4af055764ddb3--