Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100274
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <069c08bfe15b856007debab5d0d961be@bohwaz.net>
References: <1e398f12adbdbed6b7caf3b0af07f284@bohwaz.net> <CADxrgCOVu8+91THShrpGLvzqRKBr7URm69s792K2Ufi=GxoTSw@mail.gmail.com>
 <069c08bfe15b856007debab5d0d961be@bohwaz.net>
Date: Mon, 21 Aug 2017 18:02:52 -0400
Message-ID: <CADxrgCOr7fKrug=LvZeJe-52s88T+c2A5jNQbqM8WRLUcrkjhg@mail.gmail.com>
To: "BohwaZ/PHP" <php@bohwaz.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="f403045d7222ee6d2a05574aa384"
Subject: Re: [PHP-DEV] Matching PDO_SQLite features with SQLite3 extension
From: adambaratz@php.net (Adam Baratz)

--f403045d7222ee6d2a05574aa384
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 21, 2017 at 5:54 PM, BohwaZ/PHP <php@bohwaz.net> wrote:

> Le 22/08/2017 07:55, Adam Baratz a =C3=A9crit :
>
>> A new method is an API change to me, so an RFC would be warranted. I'm
>> reluctant to add driver-specific methods, since that seems opposed to
>> PDO's
>> driver-agnostic API, but that's not to say we couldn't hash something ou=
t.
>>
>
> Do we need a RFC every time we patch for a missing method ?
>
> Btw there's already sqliteCreateFunction, sqliteCreateAggregate and so on=
,
> so it's pretty much just the continuation of that logic, even though I
> don't really like it either (especially as lazy-loading by extending PDO
> makes it so that the methods are not accessible until the connection has
> been established, which is a weird behaviour imho).


I see. Didn't realize it was an existing pattern. Not going to say I love
it, but that's not a reason to break with it now. We could maybe talk
separately about better ways to do this sort of thing, to avoid the
situation you describe, but I don't need to derail this conversation any
further.

Thanks for taking the time to get parity between the extensions.

Adam

--f403045d7222ee6d2a05574aa384--