Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100194 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65067 invoked from network); 12 Aug 2017 15:54:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Aug 2017 15:54:32 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.169 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.220.169 mail-qk0-f169.google.com Received: from [209.85.220.169] ([209.85.220.169:33966] helo=mail-qk0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 10/9C-34801-7B42F895 for ; Sat, 12 Aug 2017 11:54:31 -0400 Received: by mail-qk0-f169.google.com with SMTP id u139so33658925qka.1 for ; Sat, 12 Aug 2017 08:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=+giiFOshar9+sZKiqefvpDMEJdlh4rNZinNEpZdesno=; b=QotuCSZbuX6gyN5n4YF0nMiB8FsDyHF4xVTAgFN2O+cX/6FyVt5GiLWQ1R2wd8qM5f zFqx2iw9T/AWph6Usu7pzjD2Vq2EAvjVtyws7+BmmJAC92dWaociK2EuaoWcBWMVrza8 qBwIYMKmEQ3cpiXuu7SpxWyN9Yb1h7oDMm4Rhr7zO8ykK1HoV0aYutZVxsnb+VzKOGHM rfZbBq5PAz1uGvuz6egY3ynoKq8qHIR9L7pKp3BFX4j3M9RO3fHEJ6s5Wd5sVn/vD/8R c3wouwAiXynS4We8y7ZbmQejGkBCG8B0bdk7g2wN9eDq/+EL+UwYauq76kDyAZyXSJ2c I8PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+giiFOshar9+sZKiqefvpDMEJdlh4rNZinNEpZdesno=; b=RPulVp9dM+vGusTPuBtASGasjWRNMX21/oD4+ZDmASAWTpGO+8aaVZg4Smx5YbiMKv uK0dRYb2sBknrUAw+/j9tpd7m/ODg0DZOGB9A2fgtx0+7TlRm2/n1mmM86jvqiAiwTID wcI6/LmpKdy/PP0djrZ8O1vWGw5R6U6/UiUDLOo51kjq+Y+lsOAwtqMeuScOlkCwbZke 2+MHbuGeAyatBEew9KRRhBHzEsjC72oUtW8XikVtZgdyJ22JQ6YsfK3vfE7EqUc1C/1P qpbhXCRp4DG+RQFB9ANekuETVVv/kYUaCGiK2aV4rDq/JjPJMGKXL7nh9FTwOhxTcako fChw== X-Gm-Message-State: AHYfb5i3Pym+ClbBSe4WZWaTcVJQMM8AwtKPlH9XxvLn9B7zenXk5KVp om04DmsChYgsnk4nH18= X-Received: by 10.55.33.225 with SMTP id f94mr1220222qki.292.1502553268357; Sat, 12 Aug 2017 08:54:28 -0700 (PDT) Received: from Stas-Pro-2016.local ([207.134.107.2]) by smtp.gmail.com with ESMTPSA id c39sm2506874qta.40.2017.08.12.08.54.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Aug 2017 08:54:27 -0700 (PDT) To: Rowan Collins , PHP Internals References: <7e336645-7b47-2772-257a-a51b6849e4b5@gmail.com> Message-ID: Date: Sat, 12 Aug 2017 11:54:25 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Stop Exceptions capturing object references for trace arguments From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > My only concern is if anyone is using this data for anything other than > debugging - e.g. if they were somehow extracting extra context about the > exception by traversing the backtrace to a particular point and grabbing > the arguments. That feels like a horrible hack to me, but that doesn't > mean someone isn't relying on it. Sure, that's why I propose to keep the option. If you use the horrible hack, I think it wouldn't be too much to ask to set an INI variable. Since it's rather local, it can be INI_ALL so you could do it in the script even. > An interesting side effect of an ini setting, though, is that it could > in turn be made to raise deprecation warnings at some point, whereas > just accessing the 'args' element of an array is pretty hard to detect. > So for instance, we could theoretically have: 7.3, add ini setting > defaulting to on; 7.4, change default to off and raise deprecation > notice if it's turned on; 8.0, remove feature, error if ini setting is > not set to on (ignore if set to off for smoother upgrades). Yep, sounds like a plan. Not sure if we need to drop it for 8.0 even, but we can vote on that. Anybody to make an RFC for this? :) -- Stas Malyshev smalyshev@gmail.com