Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100160
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 74.125.83.50 cause and error)
MIME-Version: 1.0
In-Reply-To: <B11F0039-0508-43B3-9873-E99AA58F12F1@bk.ru>
References: <1907EFF3-ED77-4F5C-85AA-CDFE323369C5@bk.ru> <CA+kxMuRXTxxsWyHumtGiyjU+pQ_KSTbtiNMd-V+U9YKPgxCNyA@mail.gmail.com>
 <880CDC06-17D6-4E40-8A48-F2E1CB405667@bk.ru> <CA+kxMuRXnUrnhqQQW9pj--UY8eSQoOrZriMUioG5Th_-8HmYqg@mail.gmail.com>
 <2A653728-97CA-4AA5-BA30-5BF26FABBC2A@bk.ru> <1501512881.14647.31.camel@schlueters.de>
 <94973CB5-A3F8-4BE4-9A78-8F759D1829E7@bk.ru> <1501515189.14647.35.camel@schlueters.de>
 <B11F0039-0508-43B3-9873-E99AA58F12F1@bk.ru>
Date: Sun, 6 Aug 2017 14:30:10 +0100
Message-ID: <CA+kxMuTrGdBfhRZMe=7ct3s98CHJOXvrhE1+zzc2GrAqtyOMRA@mail.gmail.com>
To: Andrew Nester <newaltgroup@bk.ru>
Cc: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface
 and PDOStatementInterface
From: danack@basereality.com (Dan Ackroyd)

Andrew Nester wrote:
> I am thinking about writing an RFC for this and continue discussion there=
.
> Will it be a good idea?

You're apparently not very good at listening to suggestions, so I'll
be more direct.

I think you're wasting people's time until you actually try seeing if
PDO can be made to work with userland classes or not.

The next step should be you (or anyone else) attempting to make the
required changes to PDO to make it work, to discover what changes
would be needed to allow using userland classes.

If it isn't known what is needed to do to support it working, there is
no point raising the RFC.


Johannes Schl=C3=BCter wrote:
> The actually question is: Why not?

My understanding is that some of the internal code that calls userland
functions and methods is basically bogus.

I had a PR (which I haven't had the energy to get round to sorting
out) to make the SPL call userland constructors correctly:
https://github.com/php/php-src/pull/1196

My surprise level would be zero, if there were similar issues in PDO
instantiating user classes, or other issues like the internal code
accessing properties directly without going through method access.

On the other hand, it might 'just work'.

cheers
Dan
Ack