Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100134
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain bk.ru designates 94.100.177.101 as permitted sender)
Message-ID: <2A653728-97CA-4AA5-BA30-5BF26FABBC2A@bk.ru>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_467DA5B1-CEFC-4634-ABD0-E5DA541A8097"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Date: Mon, 31 Jul 2017 14:49:37 +0300
In-Reply-To: <CA+kxMuRXnUrnhqQQW9pj--UY8eSQoOrZriMUioG5Th_-8HmYqg@mail.gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
To: Dan Ackroyd <danack@basereality.com>
References: <1907EFF3-ED77-4F5C-85AA-CDFE323369C5@bk.ru>
 <CA+kxMuRXTxxsWyHumtGiyjU+pQ_KSTbtiNMd-V+U9YKPgxCNyA@mail.gmail.com>
 <880CDC06-17D6-4E40-8A48-F2E1CB405667@bk.ru>
 <CA+kxMuRXnUrnhqQQW9pj--UY8eSQoOrZriMUioG5Th_-8HmYqg@mail.gmail.com>
Subject: Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface
 and PDOStatementInterface
From: newaltgroup@bk.ru (Andrew Nester)

--Apple-Mail=_467DA5B1-CEFC-4634-ABD0-E5DA541A8097
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


That=E2=80=99s actually the thing that you can=E2=80=99t use =
PDO::ATTR_STATEMENT_CLASS with persistent PDO.

To make it possible to have persistent PDO with custom PDOStatement you =
should have:
1) custom `CustomPDO implements PDOInterface` which will be somewhat =
proxy to PDO instance
2) custom `CustomPDOStatement implements PDOStatementInterface` which =
will be returned from CustomPDO::prepare and will have our additional =
logic + some stuff for persistence.

And in our userland code we can have type hints like =
`someMethod(PDOInterface $pdo)` or `someMethod(PDOStatementInterface =
$stmt)`=20

I hope it explains a bit how interfaces could help here.



> On Jul 31, 2017, at 2:17 PM, Dan Ackroyd <danack@basereality.com> =
wrote:
>=20
> On 31 July 2017 at 08:21, Andrew Nester <newaltgroup@bk.ru> wrote:
>>=20
>> when we are using persistent PDO we can=E2=80=99t use =
PDO::ATTR_STATEMENT_CLASS and
>> return our custom PDOStatement class
>>=20
>> But just implementing PDOInterface and PDOStatementInterface will =
allow us to implement
>> this and have proper type hints in userland code.
>=20
> Are you sure having interfaces would change this?
>=20
> I would assume you can't use PDO::ATTR_STATEMENT_CLASS with persistent
> PDO due to a limitation of the implementation internal to PDO, rather
> than anything to do with what sub-classes what.
>=20
> Could you post a working example of being able to set
> PDO::ATTR_STATEMENT_CLASS with persistent PDO?
>=20
> cheers
> Dan


--Apple-Mail=_467DA5B1-CEFC-4634-ABD0-E5DA541A8097--