Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100126
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.174 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CANUQDCiLR=pX+=F+sW5zgOM+ftHqhy=_OeRUoHWZPmpBQTS_Fw@mail.gmail.com>
References: <CAHE1Eds0eiCy2F-W9CUK_wRACOEsikjLeWc1JczW4+kXuRW0Fw@mail.gmail.com>
 <CANUQDCinNh5z4n_6WTJ2Ms_V9VEUiovD8-6dae_Y6Om9jj3wjA@mail.gmail.com>
 <CAHE1Eds4zvho47-yc2xfTCanQ_D8ZDVAfybR+9n0UjygoyEAgw@mail.gmail.com>
 <A6.ED.40376.EA89C795@pb1.pair.com> <CAHE1Edscjm037w80rv=aSNkYNJkbdWJBBeBDnEY+EG58=NuuJw@mail.gmail.com>
 <4F.AF.40376.40EBC795@pb1.pair.com> <CANUQDCiLR=pX+=F+sW5zgOM+ftHqhy=_OeRUoHWZPmpBQTS_Fw@mail.gmail.com>
Date: Sun, 30 Jul 2017 20:01:25 +0100
Message-ID: <CAEKnhAFpLsHG=nJP_+Fc+LAHNQfn8XMH41moTp+CQ4KWMPNFRg@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: Andrea Faulds <ajf@ajf.me>, PHP Internals <internals@lists.php.net>, Sara Golemon <pollita@php.net>
Content-Type: multipart/alternative; boundary="f403045f28ea7d90ed05558d8a21"
Subject: Re: [PHP-DEV] json_encode() / json_decode() warnings
From: bukka@php.net (Jakub Zelenka)

--f403045f28ea7d90ed05558d8a21
Content-Type: text/plain; charset="UTF-8"

On Sat, Jul 29, 2017 at 7:10 PM, Niklas Keller <me@kelunik.com> wrote:

> Andrea Faulds <ajf@ajf.me> schrieb am Sa., 29. Juli 2017, 18:55:
>
> > Hi Craig,
> >
> > Craig Duncan wrote:
> > > On 29 July 2017 at 15:16, Andrea Faulds <ajf@ajf.me> wrote:
> > >
> > >> Could we not simply make it a flag? e.g.
> > >>
> > >>     $bar = json_encode($foo, JSON_THROW_EXCEPTIONS);
> > >>     $baz = json_decode($bar, false, 512, JSON_THROW_EXCEPTIONS);
> > >>
> > >> That wouldn't break backwards-compatibility, but would still provide
> the
> > >> desired functionality. :)
> > >
> > >
> > > Hi Andrea, although that wouldn't break compatibility, it doesn't
> protect
> > > new developers from using them dangerously.
> > > That desired functionality is available in many userland libraries, I
> > don't
> > > think we gain much from adding it to core.
> > > My aim is to make the core functions easier/safer to use out of the
> box.
> >
> > That's true, but if we add it to core we can save people reimplementing
> > it themselves or adding an extra dependency, and perhaps more
> > pertinently, it could be the first step to making this the default
> > behaviour.
> >
>
> Thanks for that very good idea.
>
> @Sara: Can we please get that into 7.2?
>

I agree that it might be a useful feature for some users but I don't see
any need to break a release rules for that (I mean adding new features in
beta stage). Also the PR needs to have a full agreement which is not the
case atm. (still some open questions) so I wouldn't definitely rush with
adding that to 7.2. This should go just to master if all parts are agreed
IMHO. That's of course up to RM and this is just my opinion. :)

--f403045f28ea7d90ed05558d8a21--