Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100083
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
Date: Fri, 28 Jul 2017 15:11:16 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <ebde09b9-c883-36ef-3727-fac2ec009e6c@rhsoft.net>
References: <a9bfbaf5-6c48-ee69-62ab-b59daef3328e@rhsoft.net> <28093140-0D0D-4157-AAA3-E8F1A570E67A@gmail.com> <ebde09b9-c883-36ef-3727-fac2ec009e6c@rhsoft.net>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: internals@lists.php.net,"lists@rhsoft.net" <lists@rhsoft.net>
Message-ID: <422D7E05-864E-40EB-AEEB-81DFED80CA72@gmail.com>
Subject: Re: [PHP-DEV] session_start() should not reset $_SESSIOn if it's not empty
From: rowan.collins@gmail.com (Rowan Collins)

On 28 July 2017 14:37:10 BST, "lists@rhsoft=2Enet" <lists@rhsoft=2Enet> wro=
te:
>(Arguably, all the other superglobals should be read only for the same
>reason, but that would be a huge break now=2E)
>
>make them readonly would break my whole codebase=20

Yes, I only meant that as an absolutely hypothetical "if I had a time mach=
ine and could design it a different way=2E=2E=2E", I realise it would break=
 everything to change it now=2E


>> If I understand you right, the scenario you describe is "I don't want
>to start a session yet, but if and when I do, I want to put this data
>into it"=2E It feels like that could be adequately handled in userland
>with a wrapper object (or global var and functions if you prefer),
>which reads to and from $_SESSION when a session is open, but a a
>holding array when it's not yet=2E
>
>that don't work because at this point you don't know in userland if you
>started a completly new session which should be initialized with values
>for follow-up requests or use the existing values from a previous=20
>request - at least not without writing ugly code

Do you mean like this?

session_start();
if ( ! $_SESSION['initialised'] ) {
    $_SESSION['initialised'] =3D true;
    foreach ( $this->session_init_vars as $var =3D> $val ) {
        $_SESSION[ $var ] =3D $val;
    }
}


That should work as long as you don't run session_start() outside that fun=
ction, and centralising that is already necessary to avoid "already started=
" errors=2E

Regards,

--=20
Rowan Collins
[IMSoP]