Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100077
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain duncanc.co.uk from 209.85.220.173 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAEKnhAGVz6rd=cG5A7RaJAi_tRhiAxisbn_UWNj9RbaBrbbJDQ@mail.gmail.com>
References: <CAHE1Edu4gENzeC22wKFVuLSKV=JpE9Lymqa34b5buvTAoQHxug@mail.gmail.com>
 <CAEKnhAGVz6rd=cG5A7RaJAi_tRhiAxisbn_UWNj9RbaBrbbJDQ@mail.gmail.com>
Date: Fri, 28 Jul 2017 12:41:23 +0100
Message-ID: <CAHE1EdtfJizQcp5tatqA1A1DHJE1v1NagtBrA4um8QV0wOtmsQ@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a113f40c6227e3b05555f2951"
Subject: Re: [PHP-DEV] [RFC] Raise warnings for json_encode() and
 json_decode() issues
From: php@duncanc.co.uk (Craig Duncan)

--001a113f40c6227e3b05555f2951
Content-Type: text/plain; charset="UTF-8"

On 28 July 2017 at 12:36, Jakub Zelenka <bukka@php.net> wrote:

>
> Also it would break a big amount of code because in case of converting
> errors to exceptions, you start getting a different exception so it would
> have to be handled. I would call the whole proposal just a big BC break
> (I'm aware that we don't consider adding warnings as BC but in this case it
> is) for no benefit at all!
>
>
Hi Jakub, thanks for sharing you opinion.

While I agree there are BC concerns, I don't think it's accurate to say no
benefit at all. I regularly see new (and experienced) developers using
these functions without checking `json_last_error()`, trying to figure out
why the app is failing later without any warnings in the log can be very
difficult.

--001a113f40c6227e3b05555f2951--