Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100062
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.162 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAHE1Eds0eiCy2F-W9CUK_wRACOEsikjLeWc1JczW4+kXuRW0Fw@mail.gmail.com>
References: <CAHE1Eds0eiCy2F-W9CUK_wRACOEsikjLeWc1JczW4+kXuRW0Fw@mail.gmail.com>
Date: Thu, 27 Jul 2017 17:57:39 +0200
Message-ID: <CANUQDCinNh5z4n_6WTJ2Ms_V9VEUiovD8-6dae_Y6Om9jj3wjA@mail.gmail.com>
To: Craig Duncan <php@duncanc.co.uk>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="001a1134e218bfad9805554e9fe7"
Subject: Re: [PHP-DEV] json_encode() / json_decode() warnings
From: me@kelunik.com (Niklas Keller)

--001a1134e218bfad9805554e9fe7
Content-Type: text/plain; charset="UTF-8"

2017-07-27 17:41 GMT+02:00 Craig Duncan <php@duncanc.co.uk>:

> Hi internals,
>
> When using `json_encode()` and `json_decode()` it is required that you
> manually check for errors after every call, eg:
>
> ```php
> $data = json_decode("false");
> if (json_last_error() !== JSON_ERROR_NONE) {
>     throw new UnexpectedValueException(json_last_error_msg());
> }
> ```
>
> This isn't _that_ unusual in PHP, however normally in these situations a
> warning would be raised. But the JSON functions only raise warnings in a
> couple of scenarios, most issues are completely silent.
>
> I wanted to begin a discussion around changing this, so that warnings are
> raised for any issues during `json_encode()` and `json_decode()`.
>
> I have an implementation ready and I'm happy to draft an RFC if this
> suggestion doesn't receive universal hatred.
>

It should rather just throw exceptions. Warnings do not really allow error
handling, they just allow error reporting.

Regards, Niklas

--001a1134e218bfad9805554e9fe7--