Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100052
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.128.182 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <CAESVnVrvWP9UjmJaDa=mxzuVnsOd=CJJEDxyXb0egKUCFsD+bg@mail.gmail.com>
References: <2177132.cc4GXqHK7k@mcmic-probook> <1695890.Q3ruuQZBqi@mcmic-probook>
 <CAESVnVrvWP9UjmJaDa=mxzuVnsOd=CJJEDxyXb0egKUCFsD+bg@mail.gmail.com>
Date: Wed, 26 Jul 2017 13:06:53 -0400
Message-ID: <CAESVnVph2jE6F_mpVwhDW-Jj7vusiWuMbf9_dTe3mVRjQPgyVQ@mail.gmail.com>
To: =?UTF-8?Q?C=C3=B4me_Chilliet?= <come@opensides.be>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] LDAP controls support API [Question for the RM at the end]
From: pollita@php.net (Sara Golemon)

On Wed, Jul 26, 2017 at 12:48 PM, Sara Golemon <pollita@php.net> wrote:
> On Wed, Jul 26, 2017 at 12:11 PM, C=C3=B4me Chilliet <come@opensides.be> =
wrote:
>> As ldap_exop was merged in 7.2, is it possible to have a BC on it for 7.=
3 or not?
>> It would be by adding options in the middle:
>> resource ldap_exop(resource link, string reqoid [,
>> string reqdata [, array servercontrols [, array clientcontrols [,
>> string retdata [, string retoid]]]]])
>>
> I'll be honest, the code in this function looks bizarre to my eyes
>
Rather than vague "eww" motions, here's a (suggested) commit on a
branch in my checkout which you might choose to apply to ldap_exop()
(and perhaps apply to other functions in this file).

https://github.com/sgolemon/php-src/commit/5b3f4c2fb9e529880ec74e61f9e27aa4=
1ec7f023

Your code isn't broken as-is, these idioms are just going to make it
easier to read later on and hopefully will help you understand PHP's
module API better.

-Sara

Note: I don't know for sure if this compiles.  If not, it should at
least be close.