Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100046
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain opensides.be designates 195.154.20.141 as permitted sender)
To: internals@lists.php.net
Date: Wed, 26 Jul 2017 14:55:25 +0200
Message-ID: <2177132.cc4GXqHK7k@mcmic-probook>
Organization: OpenSides
User-Agent: KMail/5.2.3 (Linux/4.9.0-3-amd64; KDE/5.28.0; x86_64; ; )
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: LDAP controls support API
From: come@opensides.be (=?ISO-8859-1?Q?C=F4me?= Chilliet)

Hello,

I=E2=80=99m looking into adding control support to all ldap operations in p=
hp-ldap.
You can see a WIP PR here: https://github.com/php/php-src/pull/2640

Next step is to add control support for ldap_modify, ldap_add, ldap_search,=
 =E2=80=A6

The historic patch for this added functions like ldap_modify_ext, ldap_add_=
ext=E2=80=A6 for this which I would like to avoid.

So this means I cannot change the return type, only add parameters.
One solution is to change:
bool ldap_modify ( resource $link_identifier , string $dn , array $entry )
Into:
bool ldap_modify ( resource $link_identifier , string $dn , array $entry, a=
rray $servercontrols, array $clientcontrols, array &$resultcontrols )

The problem is that it still does not give access to the result object and =
thus to errmsg and referrals which can be obtained with ldap_parse_result.

So I was thinking maybe:
bool ldap_modify ( resource $link_identifier , string $dn , array $entry, a=
rray $servercontrols, array $clientcontrols, [resource &$resultobject])
=2D> if the last parameter is omitted, it works as before, if it is given, =
then the user will have to call ldap_parse_result on it to get the informat=
ion it wants.

What do you think of this solution ?
I don=E2=80=99t see any other giving access to all available information wi=
thout BC.

This will have to be changed for almost all ldap_* operations. Even ldap_bi=
nd can return controls in the result.

C=C3=B4me