Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:100018 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64073 invoked from network); 23 Jul 2017 10:52:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jul 2017 10:52:17 -0000 Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.181 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@gmail.com X-Host-Fingerprint: 209.85.223.181 mail-io0-f181.google.com Received: from [209.85.223.181] ([209.85.223.181:34389] helo=mail-io0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F6/E9-02884-0EF74795 for ; Sun, 23 Jul 2017 06:52:16 -0400 Received: by mail-io0-f181.google.com with SMTP id l7so34781500iof.1 for ; Sun, 23 Jul 2017 03:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0GmBGuiM1wT+/QDd92+v5rUVLu7lXJYAcCBn0vl7PF4=; b=Ifl9jdkTXAoCo5TA3BEREw51m9uGO8Kv65UgvWMZI4y/9MZQjuprxPZEP+/4c7jfOY ONE6iRVEjEt8hxFe1JxAXoUH9Ja27GiKulgFKr2HVu56fI8+Bvl1TnsXBqlusdbH/vOu ICTrqIOYR2pxWCiLQ/uskO5zPd+azSwbVKY2gHFyMWzWDOJ9Q3RfqQACFeFZRF7mzIFb k+ZrhT7+BA3+aZ3cQX46d03Gn/Pkdmop8irDLHlttpTRwOEBjS3Eb+BrrfWiOJnDjqg7 Wh0KNFreV7BY1KavbnBBU/xc0fOaMtV4jned3gDhfnIfv6tfpTVQ5jpSbjDwSjL60FoW WvnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0GmBGuiM1wT+/QDd92+v5rUVLu7lXJYAcCBn0vl7PF4=; b=N2mTYk/w2aKpjOH4JePPlMyJ2xxiicQVxOtby1XHpNKEpsepRioHzEmQnX6lVj0Uj/ 8pmbrQqJZJmV2hHlj4kgEd5JtTuZ1xLkp8yDzHz9/K9kNKbnleQl7aHPs6cYv+gvfjaN kofHwlBD19IbLPu9JQx69k4YRPawcPa81lKWhUTP+QYEbhL56YYaGI4R8yamBGwqaAMu qVlTNqM7IbFw2Qjo0XKW4cRQW1Udq8q7uAgvTWJIL4iKqzuy7cqT7WT4OQOIdePK2gQ5 cVgl/WXZeKqqq4erk8O1pUeAPR+BsO06486K1tZSbiJATzisKkCp509LCeWJWiFeEAVB RUdw== X-Gm-Message-State: AIVw112gpgVK/COcLRauSYqikDPI4yUzLBXtUE5cyytmLoX9a6Qdn9Ch N2ZHrQdVeoPNbEwSMijhVI7Azg818w== X-Received: by 10.107.23.194 with SMTP id 185mr12113336iox.8.1500807134215; Sun, 23 Jul 2017 03:52:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.33.4 with HTTP; Sun, 23 Jul 2017 03:52:13 -0700 (PDT) In-Reply-To: References: Date: Sun, 23 Jul 2017 12:52:13 +0200 Message-ID: To: Sara Golemon Cc: PHP internals Content-Type: multipart/alternative; boundary="94eb2c05beb41c8b130554f9e435" Subject: Re: [PHP-DEV] PHP 7.2 forked From: nikita.ppv@gmail.com (Nikita Popov) --94eb2c05beb41c8b130554f9e435 Content-Type: text/plain; charset="UTF-8" On Sun, Jul 23, 2017 at 3:55 AM, Sara Golemon wrote: > On Sat, Jul 22, 2017 at 12:48 PM, Nikita Popov > wrote: > > What's out current state regarding ABI? I've recently done some work on > > making mbstring slightly less abysmally slow, but landed the changes on > > master only, because this included ABI breaks in mbfl/mbstring APIs and > > globals. Is this something I can land in PHP-7.2, or is it closed to > > extension ABI changes? > > > During beta I'm willing to tolerate some ABI breaks for high-value > things, but while mbstring performance is inarguably a good thing, > stability is an even better thing. Anatol mentioned concern about > stability, ergo I'm inclined to defer these improvements till 7.3. > > -Sara > What Anatol is probably referring to here is that next to the performance improvements, the mbstring extension has also been migrated to use size_t instead of int lengths. This is something we originally overlooked during the size_t port in PHP 7. This is a major change and its easy to overlook something, so the concern for stability is well justified. Conversely, this does also fix a range of length overflow related bugs (I have manually verified this on a sample of related bug reports). Nikita --94eb2c05beb41c8b130554f9e435--