Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:100002
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.218.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <tea5nc108tqnnrj2utb6q3umtkklrm57p5@4ax.com>
References: <CAESVnVquvSq8KaixxRUcuV4n9k4kYwE1SSn_v-0RvHE8uVCVGQ@mail.gmail.com>
 <tea5nc108tqnnrj2utb6q3umtkklrm57p5@4ax.com>
Date: Fri, 21 Jul 2017 22:15:13 -0400
Message-ID: <CACXBjugBV6+Vbn3dNyawHfOBUozSSX5FLeff8+8Pv_FUKE=6Dw@mail.gmail.com>
To: Jan Ehrhardt <phpdev@ehrhardt.nl>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c18d62cb60cd10554de8fcc"
Subject: Re: [PHP-DEV] Re: PHP 7.2.0 Beta 1 released
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--94eb2c18d62cb60cd10554de8fcc
Content-Type: text/plain; charset="UTF-8"

On Fri, Jul 21, 2017 at 9:50 PM, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote:
>
> I tried running Drupal7 with 7.2.0 Beta 1 and ran into a fatal error,
> that does not happen under PHP 7.1.x (Windows, NTS, x64). I do not know
> if it is a bug, an omission in UPGRADING or me looking with my nose.
> Therefore I did not file a bugreport yet.
>
> The case: class RulesActionContainerUI has a public function form:
> > public function form(&$form, &$form_state, $options = array(), $iterator
> = NULL) {
>
> class RulesRuleUI extends RulesActionContainerUI with a public function
> > public function form(&$form, &$form_state, $options = array()) {
>
> Bad programming, but no PHP ever stumbled over it. PHP 7.2.0 Beta 1
> issues a fatal error that RulesRuleUI::form must be compatible with
> RulesActionContainerUI::form. IMHO a valid remark, but still a BC break.
> Is this documented anywhere? Or should the Fatal Error become less
> fatal?
>

This sounds strange. This hasn't changed in 7.2. It was the same in 7.1 and
7.0. Even in 5.6 and 5.5 it was an E_STRICT. Unless the Windows version has
somehow drifted, but I don't see how that would be possible. Are you sure
it isn't caused by something else?

eg.

 10:10pm thinkpad:~/php-src> cat -n g
     1 <?php
     2 class P {
     3    public function form(&$form, &$form_state, $options = array(),
$iterator = NULL) { }
     4 }
     5
     6 class C extends P {
     7    public function form(&$form, &$form_state, $options = array()) { }
     8 }
10:10pm thinkpad:~/php-src> php g

Warning: Declaration of C::form(&$form, &$form_state, $options = Array)
should be compatible with P::form(&$form, &$form_state, $options = Array,
$iterator = NULL) in /home/rasmus/php-src/g on line 8
10:10pm thinkpad:~/php-src> php -v
PHP 7.2.0-dev (cli) (built: Jul 21 2017 22:08:10) ( NTS )

10:10pm thinkpad:~/php-src> sudo newphp 71
Activating PHP 7.1.3-dev (cli) (built: Feb 11 2017 09:40:56) ( NTS ) and
restarting php-fpm
10:10pm thinkpad:~/php-src> php g

Warning: Declaration of C::form(&$form, &$form_state, $options = Array)
should be compatible with P::form(&$form, &$form_state, $options = Array,
$iterator = NULL) in /home/rasmus/php-src/g on line 8

10:10pm thinkpad:~/php-src> php -v
PHP 7.1.3-dev (cli) (built: Feb 11 2017 09:40:56) ( NTS )

-Rasmus

--94eb2c18d62cb60cd10554de8fcc--