Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123250
Precedence: bulk
MIME-Version: 1.0
References: <CAEPJdumvJNQ+JZ3wkLP-Q2O0y57g=W_hHFkuvOKMVJqqraKCzw@mail.gmail.com>
In-Reply-To: <CAEPJdumvJNQ+JZ3wkLP-Q2O0y57g=W_hHFkuvOKMVJqqraKCzw@mail.gmail.com>
Date: Thu, 2 May 2024 13:00:41 +0200
Message-ID: <CAEPJduku=Sdptw4zDDgTHzZ7SW0KDFHaoF5op5vjLAXk9344Vw@mail.gmail.com>
Subject: [PHP-DEV] Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3
To: PHP Internals <internals@lists.php.net>
Cc: "tim@tideways-gmbh.com" <tim@tideways-gmbh.com>
Content-Type: multipart/alternative; boundary="000000000000437501061776840b"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--000000000000437501061776840b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 23, 2024 at 3:27=E2=80=AFPM Benjamin Au=C3=9Fenhofer <kontakt@b=
eberlei.de>
wrote:

> Hi internals,
>
> My PR for #[\Deprecated] attribute was in hibernation for a long while no=
w
> and after some off-list discussion a few weeks ago I have decided to
> revisit it and asked Tim to help me out with the work.
>
> Tim has cleaned up the PR quite a bit and also worked in additional
> features such as #[Deprecated] support in stub generation.
>
> While there are still some small todos, at this point we want to restart
> the discussion about the RFC for inclusion in 8.4:
>
> RFC: https://wiki.php.net/rfc/deprecated_attribute
> PR: https://github.com/php/php-src/pull/11293
> Old discussion: https://externals.io/message/112554#112554
>
> Let me know about your questions and feedback.
>
> greetings
> Benjamin
>

We have updated the RFC and PR to include #[Deprecated] on class constants
and enum cases as this is something the engine already supports for
internal class constants.

This does not include support for non-class based constants, because they
don't have support for attributes at the moment and also only recently got
reflection support (for 8.4).

We are planning to work on adding $since next and get back to the list once
that is finished.

--000000000000437501061776840b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, Apr 23, 2024 at 3:27=E2=80=AF=
PM Benjamin Au=C3=9Fenhofer &lt;<a href=3D"mailto:kontakt@beberlei.de">kont=
akt@beberlei.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:so=
lid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">H=
i internals,<div><br></div><div>My PR for #[\Deprecated] attribute was in h=
ibernation for a long while now and after some off-list discussion a few we=
eks ago I have decided to revisit it and asked Tim to help me out with the =
work.</div><div><br></div><div>Tim has cleaned up the PR quite a bit and al=
so worked in additional features such as #[Deprecated] support in stub gene=
ration.</div><div><br></div><div>While there are still some small todos, at=
 this point we want to restart the discussion about the RFC for inclusion i=
n 8.4:</div><div><br></div><div>RFC: <a href=3D"https://wiki.php.net/rfc/de=
precated_attribute" target=3D"_blank">https://wiki.php.net/rfc/deprecated_a=
ttribute</a><br></div><div>PR: <a href=3D"https://github.com/php/php-src/pu=
ll/11293" target=3D"_blank">https://github.com/php/php-src/pull/11293</a><b=
r></div><div>Old discussion:=C2=A0<a href=3D"https://externals.io/message/1=
12554#112554" target=3D"_blank">https://externals.io/message/112554#112554<=
/a></div><div><br></div><div>Let me know about your questions and feedback.=
</div><div><br></div><div>greetings</div><div>Benjamin</div></div></blockqu=
ote><div><br></div><div>We have updated the RFC and PR to include #[Depreca=
ted] on class constants and enum cases as this is something the engine alre=
ady supports for internal class constants.=C2=A0</div><div><br></div><div>T=
his does not include support for non-class based constants, because they do=
n&#39;t have support for attributes at the moment and also only recently go=
t reflection support (for 8.4).</div><div><br></div><div>We are planning to=
 work on adding $since next and get back to the list once that is finished.=
</div></div></div>

--000000000000437501061776840b--