Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123205
Precedence: bulk
MIME-Version: 1.0
References: <CAEPJdumvJNQ+JZ3wkLP-Q2O0y57g=W_hHFkuvOKMVJqqraKCzw@mail.gmail.com>
 <CANS-=pdE8GX8-qpn3iZ_A7ZDKRW27mUhwA14rAtJmZOyZWa1-w@mail.gmail.com>
 <CAEPJdukkD_3PhP5mHogX4-LNNGFbRPiwU0zvgAvK9uaAHdy0yA@mail.gmail.com> <CAPTD5yHzg-Rm+2sFqSbzj4pyU40MMg_4tMME88W_Mqf4yKK_yw@mail.gmail.com>
In-Reply-To: <CAPTD5yHzg-Rm+2sFqSbzj4pyU40MMg_4tMME88W_Mqf4yKK_yw@mail.gmail.com>
Date: Thu, 25 Apr 2024 07:16:44 +0200
Message-ID: <CAEPJdumF6btkvNN6uBNevfvtnejeHA=jX7v1AEn9PHh6vykcgQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3
To: Jorg Sowa <jorg.sowa@gmail.com>
Cc: Lynn <kjarli@gmail.com>, PHP Internals <internals@lists.php.net>, 
	"tim@tideways-gmbh.com" <tim@tideways-gmbh.com>
Content-Type: multipart/alternative; boundary="000000000000564f830616e4e5da"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--000000000000564f830616e4e5da
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 24, 2024 at 7:18=E2=80=AFPM Jorg Sowa <jorg.sowa@gmail.com> wro=
te:

> I like the proposition and I like the idea of $since parameter, however,
> this option is too ambiguous about what should store. Should it store the
> PHP version, package version, or the date?
>
> What about setting this parameter vaguely as the boolean we can pass?
>
> #[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION)]
> class Deprecated
> {
>     public function __construct(
>         public readonly ?string $note =3D null,
>         public readonly ?bool $since =3D null
>     ) {
>     }
> }
>
> #[Deprecated(since: $packageVersion > 5.5)]
> #[Deprecated(since: PHP_VERSION_ID > 80100)]
> #[Deprecated(since: date("Y-m-d") > "2024-01-21")]
>

These are not valid uses of attributes, the expressions for since parameter
are illegal in the language.

PHP Fatal error:  Constant expression contains invalid operations in
/private/tmp/dep.php on line 6

And this proposal would only make the condition human readable, the machine
would see $since as either true or false, and that is not really something
that tools will find valuable enough.

But I agree on $since being less useful, users could put a date, a string,
or anyhing in there.

The way I see it vendors should add their own attributes, example:

#[\Deprecated, Since(package: "symfony/http-request", version: "7.0.2")]

or for PHPStorms replacement functinoality (potentially usable by Rector):

#[]Deprecated, Replacement('%class%->setPublic(!%parameter0%)')]

This is
a.) composable, which increases the potential use-cases for different
vendor and communities and doesn't restrict them to what core "designed in
the ivory tower once".
b.) allows vendors to have very strict validation on their attributes
arguments. I.e. Symfony could enforce package to be a valid composer
package string and version to follow composers version parser. This is
something we cannot enforce in the engine.

>
> Kind regards,
> Jorg
>

--000000000000564f830616e4e5da
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Apr 24, 2024 at 7:18=E2=80=AF=
PM Jorg Sowa &lt;<a href=3D"mailto:jorg.sowa@gmail.com">jorg.sowa@gmail.com=
</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left=
-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div><div><div>I=
 like the proposition and I like the idea of $since parameter, however, thi=
s option is too ambiguous about what should store. Should it store the PHP =
version, package version, or the date?<br><br></div>What about setting this=
 parameter vaguely as the boolean we can pass?<br><br>
#[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION)]<br>
class Deprecated<br>
{<br>
=C2=A0 =C2=A0 public function __construct(<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 public readonly ?string $note =3D null,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 public readonly ?bool $since =3D null<br>
=C2=A0 =C2=A0 ) {<br>
=C2=A0 =C2=A0 }<br>
}<br>
<br>
#[Deprecated(since: $packageVersion &gt; 5.5)]<br>#[Deprecated(since: PHP_V=
ERSION_ID &gt; 80100)]<br>#[Deprecated(since: date(&quot;Y-m-d&quot;) &gt; =
&quot;2024-01-21&quot;)]<br></div></div></div></blockquote><div><br></div><=
div>These are not valid uses of attributes, the expressions for since param=
eter are illegal in the language.=C2=A0</div><div><br></div><div>PHP Fatal =
error: =C2=A0Constant expression contains invalid operations in /private/tm=
p/dep.php on line 6</div><div><br></div><div>And this proposal would only m=
ake the condition human readable, the machine would see $since as either tr=
ue or false, and that is not really something that tools will find valuable=
 enough.=C2=A0</div><div><br></div><div>But I agree on $since being less us=
eful, users could put a date, a string, or anyhing in there.=C2=A0</div><di=
v><br></div><div>The way I see it vendors should add their own attributes, =
example:</div><div><br></div><div>#[\Deprecated, Since(package: &quot;symfo=
ny/http-request&quot;, version: &quot;7.0.2&quot;)]</div><div><br></div><di=
v>or for PHPStorms replacement functinoality (potentially usable by Rector)=
:</div><div><br></div><div>#[]Deprecated, Replacement(<span style=3D"color:=
rgb(19,19,19);font-size:0.9em">&#39;%class%-&gt;setPublic(!%parameter0%)=
9;)]</span></div><div><span style=3D"color:rgb(19,19,19);font-size:0.9em"><=
br></span></div><div><span style=3D"color:rgb(19,19,19);font-size:0.9em">Th=
is is=C2=A0</span></div><div><span style=3D"color:rgb(19,19,19);font-size:0=
.9em">a.) composable, which increases the potential use-cases for different=
 vendor and communities and doesn&#39;t restrict them to what core &quot;de=
signed in the ivory tower once&quot;.</span></div><div><span style=3D"color=
:rgb(19,19,19);font-size:0.9em">b.) allows vendors to have very strict vali=
dation on their attributes arguments. I.e. Symfony could enforce package to=
 be a valid composer package string and version to follow composers version=
 parser. This is something we cannot enforce in the engine.</span></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padd=
ing-left:1ex"><div dir=3D"ltr"><div><div>
<br></div>Kind regards,<br></div>Jorg<br></div>
</blockquote></div></div>

--000000000000564f830616e4e5da--