Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123203
Precedence: bulk
MIME-Version: 1.0
References: <CAEPJdumvJNQ+JZ3wkLP-Q2O0y57g=W_hHFkuvOKMVJqqraKCzw@mail.gmail.com>
 <CANS-=pdE8GX8-qpn3iZ_A7ZDKRW27mUhwA14rAtJmZOyZWa1-w@mail.gmail.com> <CAEPJdukkD_3PhP5mHogX4-LNNGFbRPiwU0zvgAvK9uaAHdy0yA@mail.gmail.com>
In-Reply-To: <CAEPJdukkD_3PhP5mHogX4-LNNGFbRPiwU0zvgAvK9uaAHdy0yA@mail.gmail.com>
Date: Wed, 24 Apr 2024 19:18:28 +0200
Message-ID: <CAPTD5yHzg-Rm+2sFqSbzj4pyU40MMg_4tMME88W_Mqf4yKK_yw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3
To: =?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?= <kontakt@beberlei.de>
Cc: Lynn <kjarli@gmail.com>, PHP Internals <internals@lists.php.net>, 
	"tim@tideways-gmbh.com" <tim@tideways-gmbh.com>
Content-Type: multipart/alternative; boundary="00000000000090ccd50616dadc06"
From: jorg.sowa@gmail.com (Jorg Sowa)

--00000000000090ccd50616dadc06
Content-Type: text/plain; charset="UTF-8"

I like the proposition and I like the idea of $since parameter, however,
this option is too ambiguous about what should store. Should it store the
PHP version, package version, or the date?

What about setting this parameter vaguely as the boolean we can pass?

#[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION)]
class Deprecated
{
    public function __construct(
        public readonly ?string $note = null,
        public readonly ?bool $since = null
    ) {
    }
}

#[Deprecated(since: $packageVersion > 5.5)]
#[Deprecated(since: PHP_VERSION_ID > 80100)]
#[Deprecated(since: date("Y-m-d") > "2024-01-21")]

Kind regards,
Jorg

--00000000000090ccd50616dadc06
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div><div>I like the proposition and I like the idea =
of $since parameter, however, this option is too ambiguous about what shoul=
d store. Should it store the PHP version, package version, or the date?<br>=
<br></div>What about setting this parameter vaguely as the boolean we can p=
ass?<br><br>
#[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION)]<br>
class Deprecated<br>
{<br>
=C2=A0 =C2=A0 public function __construct(<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 public readonly ?string $note =3D null,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 public readonly ?bool $since =3D null<br>
=C2=A0 =C2=A0 ) {<br>
=C2=A0 =C2=A0 }<br>
}<br>
<br>
#[Deprecated(since: $packageVersion &gt; 5.5)]<br>#[Deprecated(since: PHP_V=
ERSION_ID &gt; 80100)]<br>#[Deprecated(since: date(&quot;Y-m-d&quot;) &gt; =
&quot;2024-01-21&quot;)]<br>
<br></div>Kind regards,<br></div>Jorg<br></div>

--00000000000090ccd50616dadc06--