, internals@lists.php.net X-Mailer: iPhone Mail (21E236) From: php-lists@koalephant.com (Stephen Reay) --Apple-Mail-B64E7046-0BA4-457A-9A75-2B5B8F091E61 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
=

Sent from my iPhone

On 23 Apr 2024, at 19:26, Lynn <kjarli@gmail.com> wrote:<= br>

=EF=BB=BF=

<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, Apr 23, 2024 at 11:26=E2=80=AFA= M Stephen Reay <php-lists@koa= lephant.com> wrote:

Sent from my iPhone
On 23 Apr 2024, at 18:21, Lynn <kjarli@gmail.com> wrote:
<= br>
=EF=BB=BF

On Tue, Apr 23, 2024 at 10:21=E2=80=AFAM B= ilge <bilge@s= criptfusion.com> wrote:
On 21/04/2024 14:00, Saki Takamachi wrote:
> Hi internals,
>
> Recently I've been working on an RFC regarding object support for BCMat= h. While working on that, I learned of the following RFC:
> https://wiki.php.net/rfc/namespaces_in_b= undled_extensions
>
> If we follow this RFC, is it reasonable to place subclasses of PDO unde= r the namespace "PDO=E2=80=9D?
>
> e.g.
> ```
> PdoMysql =3D> PDO\Mysql
> PdoPgsql =3D> PDO\Pgsql
> PdoSqlite =3D> PDO\Sqlite
> PdoOdbc =3D> PDO\Odbc
> PdoDblib =3D> PDO\Dblib
> PdoFirebird =3D> PDO\Firebird
> ```
>
> We'll probably get a BC Break if try to fix this after 8.4 is released,= so before it's released is last chance to fix this safely.
>
> If Tim's RFC under discussion is passed, the namespace will be "Pdo" in= stead of "PDO=E2=80=9D.
> https://wiki.php.net/rfc/class-naming-acronyms<= br> >
> I would appreciate hearing your opinions.
>
> Regards,
>
> Saki

Hi Saki,

Consider that adding a namespace does not/should not change the class
name. That is, `MyClass` once namespaced becomes `MyNamespace\MyClass`.
= Ergo, `PdoMysql` becomes `Pdo\PdoMysql`. The class name should still
make sense and be a "strong name" (without conflict) once imported.

To state it more concretely, I believe it is normal and correct to
include 1-3 namespace components within the class name itself, in order
= to create such a "strong name". As a more concrete example of this,
consider `HttpClient`, `FtpClient` and `SoapClient`. Far too often, we
see user libraries (incorrectly) namespace these as `Http\Client`,
`Ftp\Client` and `Soap\Client` (or similar) where the leaf name just
becomes `Client`. "Client", by itself is a meaningless moniker, but that is all we see once the name is imported, notwithstanding importing
multiple of these clients in one file causes conflicts that now need to
= be resolved with local aliases. In general, I believe aliasing to be an
= anti-pattern that points to a failure to create strong names and thus
should be avoided by including some of the namespace portion in the
class name to make the class name more meaningful. Once imported, we do
= not see the namespace portion within the body of the file any more;
`HttpClient` and `FtpClient` make much more sense by themselves, whether or not they would otherwise conflict.

Kind regards,
Bilge

The code base I work in has 25 cla= sses that are called "Line". They have namespaces like `App\Model\Invoice\Li= ne`, this is cumbersome to work with so I would also prefer something like `= Pdo\PdoMysql`, even if it's not likely to conflict with a name such as Mysql= .

I don't think it's appropriate to claim that a n= amespace like MyLib\HTTP\Client is categorically "wrong".

The argument that "Client" is meaningless becomes pretty moot when yo= u realise that you can import a *namespace* and use it relatively, if you so= wish:

```

import MyLib\HTTP;

$a =3D new HTTP\Client(...);

```

I'm not claiming that any particular import pattern is more "cor= rect" (and I think it's a bad idea to suggest that other usage patterns are "= incorrect") but adding repetitive prefixes kind of defeats the purpose of na= mespaces.

You may as well just go back to MyLib_HTT= P_Client, and ignore that namespaces exist.

In your own codebase you should do what works best for you= . When it comes to vendor classes I don't want to have to scroll through a l= ist of 20 identical classes to find the one in the right namespace. It requi= res extra development and review effort to figure out if the right class cal= led "Client" or "Factory" is used. For reference, I have 12 "Response", 12 "= Client", 20 "Factory", and 20 "TestCase" classes in this project, of wh= ich most are vendors.

If the proposal was to have `PDO\MySQL\Client`, I would be sympa= thetic to your view. I wouldn't agree with you that it's somehow wrong or ha= rd to use, but I'd be sympathetic.

That isn't what'= s being suggested.

I also don't really see ho= w vendor use is relevant here. What third party userland libraries do is lar= gely just on a whim of whatever new shiny thing PHP-FIG pumps out to feel im= portant. This seems like the wrong place to complain about namespacing pract= ices of vendor libraries.

The PHP RFC refere= nced applies to bundled php extensions, like... PDO and the various drivers f= or it.

Using partially importe= d namespaces and aliases causes inconsistencies that makes it harder to find= things.

I honestly d= on't know what you're talking about here.

No= body here is advocating for MyLibHttpClient class names either.
<= /div>

The person you replied to litera= lly said:

On 23 Apr 2024, at 17:46, Bilge <= ;bilge@scriptfusion.com> wrote:

I believe it is normal and correct to include 1-3 namespace compone= nts within the class name itself

MyLibHttpClient easily fa= lls within that description.

= --Apple-Mail-B64E7046-0BA4-457A-9A75-2B5B8F091E61--