Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:123019
Message-ID: <36a96673-cf7b-4ffe-a86f-ee470d95a39b@bastelstu.be>
Date: Sun, 7 Apr 2024 18:45:24 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [Discussion] Support object type in BCMath
To: Saki Takamachi <saki@sakiot.com>, Derick Rethans <derick@php.net>
Cc: php internals <internals@lists.php.net>
References: <4F094EDA-5058-407D-AF39-06FD934FDE1F@sakiot.com>
 <bbcff629-4dd6-bc50-ac9f-641849dc218a@php.net>
 <68CF373E-6ABF-4471-8992-813B4BA1B508@sakiot.com>
 <62e27e46-f911-5a71-6527-8bba21bf0964@php.net>
 <48803EBD-33BB-4433-B125-448759A81868@sakiot.com>
Content-Language: en-US
In-Reply-To: <48803EBD-33BB-4433-B125-448759A81868@sakiot.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 3/28/24 14:30, Saki Takamachi wrote:
> Thanks. Sorry, I meant "If I create dedicated exception classes, do I need separate classes for each type of error?” I couldn't write it well in English.

To answer this question, even if it is not necessary after all:

You should create separate classes for each type of error the user is 
expected to handle differently so that developers to not need to check 
the exception message to find out what the error was in their code.

Here's an insightful GitHub comment from Danack: 
https://github.com/php/php-src/pull/9071#issuecomment-1193162754

And here's the PR adding a proper Exception hierarchy to ext/random: 
https://github.com/php/php-src/pull/9220

For ext/date, here's the RFC adding the new Exception hierarchy: 
https://wiki.php.net/rfc/datetime-exceptions. If I remember correctly, 
the choices made for ext/date followed the precedent set by ext/random.

Best regards
Tim Düsterhus