Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122957
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PHP-DEV] [RFC] [Discussion] Support object type in BCMath
Date: Fri, 5 Apr 2024 17:37:49 +0900
Message-ID: <1F912518-DE28-4E83-B9AA-AC135822B306@sakiot.com>
References: <5876c04a-bfed-4a97-be65-f8b64ddef31a@redmagic.org.uk>
Cc: Jordan LeDoux <jordan.ledoux@gmail.com>, internals@lists.php.net
In-Reply-To: <5876c04a-bfed-4a97-be65-f8b64ddef31a@redmagic.org.uk>
To: Barney Laurance <barney@redmagic.org.uk>
From: saki@sakiot.com (Saki Takamachi)

Hi Barney,

> Ah ok. Maybe that's the standard way internal classes are written, and we c=
an consider it generally an error for a child class to override the construc=
tor without calling `parent::__construct()`. I know tools warn users not to f=
orget the parent call.

Thanks, A fallback would be possible to always set the initial value to 0, b=
ut an error would probably be easier to understand.


> And I had been thinking of BcNum as a readonly class, but I see it's not a=
n readonly class, it's a mutable class with its one and only property being r=
eadonly.  I agree that it seems unnecessary to force child classes to be imm=
utable - I wasn't concerned about them adding additional, mutable, propertie=
s, only about leaving the value property uninitialized. (Btw I would have su=
pported the 1st part of the 2022 Readonly amendments RFC, which I think woul=
d have made a readonly class behave the same as a class where every property=
 is readonly, particularly since would have allowed implementing the example=
 given on the Wikipedia page for LSP: a circle with fixed centre and mutable=
 radius may inherit from an immutable point)

Ah, sorry about that, I completely forgot about the readonly class! In that c=
ase, it might make sense to make the classes completely immutable, since use=
rs are already accustomed to using such classes.

This is a departure from what I said in my previous email, but how do you th=
ink about making it a read-only class?

Regards.

Saki=