Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122785
Date: Thu, 28 Mar 2024 10:33:26 +0000
To: Claude Pache <claude.pache@gmail.com>
Cc: =?utf-8?B?7ZWY64qY7JWE67aA7KeA?= <daddyofsky@gmail.com>, internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC idea introduce] The issue where the __callStatic magic method is not called when statically calling a public method.
Message-ID: <8M2JTiUj7hdga1-ztER0KecraYT8pfwzSZPv0x64iikdUvBCK7n1rPzhacfBpkd8qQOiid7gSMpKeG9Zc4jtEIcl8U6LT05ou4X1RhDgPlM=@chstudio.fr>
In-Reply-To: <3ECDC57B-9D22-4A0C-8E02-5720C90EF3BA@gmail.com>
References: <CAKkgovQURx7x=P1Ybv60NHUNYqSoLXVgyna9goFYrb6i+gP_3A@mail.gmail.com> <3ECDC57B-9D22-4A0C-8E02-5720C90EF3BA@gmail.com>
Feedback-ID: 41282912:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="------fe17071dcb79ab7c12a8152ce12fcd7ec04c1444ce33e37592e701ae2cf74d63"; charset=utf-8
From: s.hulard@chstudio.fr (=?utf-8?Q?St=C3=A9phane_Hulard?=)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--------fe17071dcb79ab7c12a8152ce12fcd7ec04c1444ce33e37592e701ae2cf74d63
Content-Type: multipart/mixed;boundary=---------------------1f9a3d482ea8b29c5215306880b9afbf

-----------------------1f9a3d482ea8b29c5215306880b9afbf
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;charset=utf-8

Le jeudi 28 mars 2024 =C3=A0 10:40, Claude Pache <claude.pache@gmail.com> =
a =C3=A9crit=C2=A0:

> =


> =


> > Le 28 mars 2024 =C3=A0 03:29, =ED=95=98=EB=8A=98=EC=95=84=EB=B6=80=EC=A7=
=80 <daddyofsky@gmail.com> a =C3=A9crit :
> > =


> > =


> > Hi.
> > =


> > I would like to register an RFC on the following issue.
> > https://github.com/php/php-src/issues/13813
> > =


> > To summarize briefly, users expect that the `__callStatic` magic metho=
d will be called in all cases when a method is not static while using the =
`__callStatic`. However, in reality, if the method is public, the `__callS=
tatic` magic method is not called, and an error still occurs.
> > =


> > I would like to hear your opinions.
> > I also hope someone can help with the RFC registration.
> > =


> > =


> > --------------------------------------------------------
> > =


> > ```php
> > <?php
> > class MyClass
> > {
> > public static function __callStatic($method, $args)
> > {
> > echo $method . "\n";
> > }
> > =


> > private function privateMethod() {}
> > protected function protectedMethod() {}
> > public function publicMethod() {}
> > }
> > =


> > MyClass::privateMethod();
> > MyClass::protectedMethod();
> > MyClass::publicMethod();
> > ```
> > =


> > Resulted in this output:
> > ```
> > privateMethod
> > protectedMethod
> > Fatal error: Uncaught Error: Non-static method MyClass::publicMethod()=
 cannot be called statically in ...
> > ```
> > =


> > But I expected this output instead:
> > ```
> > privateMethod
> > protectedMethod
> > publicMethod
> > ```
> > =


> > =


> =


> =


> Hi,
> One of the issue is that it is not possible to determine statically that=
 a certain call is static or not. It is possible to determine it at runtim=
e; but you must be careful to articulate clearly the rules. Although it is=
 absolutely possible to have logical rules, I fear that they couldn=E2=80=99=
t be sufficiently simple in order to avoid confusion.
> =


> In the following real-world (but hopefully rare) case (it is taken from =
my own codebase), I am calling a method of a grandparent class. It is *not=
* a static method:
> =


> ```php
> =


> foo =3D new class(/* ... */) extends Bar {
> =


> =C2=A0 =C2=A0 // ...
> =


> =C2=A0 =C2=A0 function Header() {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 $grandparent_class =3D get_parent_class(pare=
nt::class);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 $grandparent_class::Header();
> =C2=A0 =C2=A0 =C2=A0 =C2=A0// ... rest of code
> =C2=A0 =C2=A0 }
> =


> =C2=A0 =C2=A0// ...
> };
> ```
> =


> In the following more general case, I might intend to call to a static m=
ethod. However, as of today, a call to a non-static method will occur if =C2=
=A0`A` has a non-static accessible method `qux()` *and* `$this` is an in=
stance of `A`:
> =


> ```php
> class Foo {
> =C2=A0 =C2=A0 function baz() {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 A::qux();
> =C2=A0 =C2=A0 }
> }
> ```
> =


> (In older versions of PHP, a non-static call would occur even when `$thi=
s` is not an instance of `A`. Hopefully, this is no longer the case since =
PHP 8.)
> =


> =


> =E2=80=94Claude

Hello !

In Laravel the static versus non static context is handled inside the diff=
erent calls. So a static call on a non static method will be forwarded to =
a non static instance to be handled properly.
I don't see any advantages to call `__callStatic` on any method call since=
 the difference with `__call` is clear. Also, as Claude said, determining =
that the call is static or not is not easy.

Also, building Singleton is possible using the current PHP behavior. An ex=
ample :

```php
<?php

class User
{
    public function __callStatic($name, $arguments)
    {
        return (new static)->$name(...$arguments);
    }

    public static function __call($name, $arguments)
    {
        // Here handle the call the $name method.
        echo $name;
    }
}

$user =3D User::find(1);
//Will output
//   find
```

That's the way it's done in Laravel. Also note that the find method doesn'=
t exists in the User object. That's why it works, the method is truly "mag=
ic".
If the method is defined as non static, it'll break with the error given.

St=C3=A9phane
-----------------------1f9a3d482ea8b29c5215306880b9afbf--

--------fe17071dcb79ab7c12a8152ce12fcd7ec04c1444ce33e37592e701ae2cf74d63
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: ProtonMail

wnUEARYKACcFgmYFR2AJkFAFamSXyqbjFiEEAbZnit5cX2dsfkYRUAVqZJfK
puMAAGO0AQDEA6Uc6VDI+8QZP4ozROv3NEEDICBOItcgf6fpBpB5hwEAvPGc
wrmg+i5MnjTohzKyPTG63xPW4UhoMkVNSExnkg4=
=cic0
-----END PGP SIGNATURE-----


--------fe17071dcb79ab7c12a8152ce12fcd7ec04c1444ce33e37592e701ae2cf74d63--