Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122784
Message-ID: <3ECDC57B-9D22-4A0C-8E02-5720C90EF3BA@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_83546924-0DDD-49E5-910A-83663045C684"
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\))
Subject: Re: [PHP-DEV] [RFC idea introduce] The issue where the __callStatic
 magic method is not called when statically calling a public method.
Date: Thu, 28 Mar 2024 10:40:14 +0100
In-Reply-To: <CAKkgovQURx7x=P1Ybv60NHUNYqSoLXVgyna9goFYrb6i+gP_3A@mail.gmail.com>
Cc: internals@lists.php.net
To: =?utf-8?B?7ZWY64qY7JWE67aA7KeA?= <daddyofsky@gmail.com>
References: <CAKkgovQURx7x=P1Ybv60NHUNYqSoLXVgyna9goFYrb6i+gP_3A@mail.gmail.com>
From: claude.pache@gmail.com (Claude Pache)


--Apple-Mail=_83546924-0DDD-49E5-910A-83663045C684
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> Le 28 mars 2024 =C3=A0 03:29, =ED=95=98=EB=8A=98=EC=95=84=EB=B6=80=EC=A7=
=80 <daddyofsky@gmail.com> a =C3=A9crit :
>=20
> Hi.
>=20
> I would like to register an RFC on the following issue.
> https://github.com/php/php-src/issues/13813
>=20
> To summarize briefly, users expect that the `__callStatic` magic =
method will be called in all cases when a method is not static while =
using the `__callStatic`. However, in reality, if the method is public, =
the `__callStatic` magic method is not called, and an error still =
occurs.
>=20
> I would like to hear your opinions.
> I also hope someone can help with the RFC registration.
>=20
>=20
> --------------------------------------------------------
>=20
> ```php
> <?php
> class MyClass
> {
> public static function __callStatic($method, $args)
> {
> echo $method . "\n";
> }
>=20
> private function privateMethod() {}
> protected function protectedMethod() {}
> public function publicMethod() {}
> }
>=20
> MyClass::privateMethod();
> MyClass::protectedMethod();
> MyClass::publicMethod();
> ```
>=20
> Resulted in this output:
> ```
> privateMethod
> protectedMethod
> Fatal error: Uncaught Error: Non-static method MyClass::publicMethod() =
cannot be called statically in ...
> ```
>=20
> But I expected this output instead:
> ```
> privateMethod
> protectedMethod
> publicMethod
> ```
>=20
>=20
>=20


Hi,

One of the issue is that it is not possible to determine statically that =
a certain call is static or not. It is possible to determine it at =
runtime; but you must be careful to articulate clearly the rules. =
Although it is absolutely possible to have logical rules, I fear that =
they couldn=E2=80=99t be sufficiently simple in order to avoid =
confusion.

In the following real-world (but hopefully rare) case (it is taken from =
my own codebase), I am calling a method of a grandparent class. It is =
*not* a static method:

```php

foo =3D new class(/* ... */) extends Bar {

    // ...

    function Header() {
        $grandparent_class =3D get_parent_class(parent::class);
        $grandparent_class::Header();
       // ... rest of code
    }

   // ...
};
```

In the following more general case, I might intend to call to a static =
method. However, as of today, a call to a non-static method will occur =
if  `A` has a non-static accessible method `qux()` *and* `$this` is an =
instance of `A`:

```php
class Foo {
    function baz() {
        A::qux();
    }
}
```

(In older versions of PHP, a non-static call would occur even when =
`$this` is not an instance of `A`. Hopefully, this is no longer the case =
since PHP 8.)


=E2=80=94Claude=

--Apple-Mail=_83546924-0DDD-49E5-910A-83663045C684
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: =
after-white-space;"><br><div><blockquote type=3D"cite"><div>Le 28 mars =
2024 =C3=A0 03:29, =ED=95=98=EB=8A=98=EC=95=84=EB=B6=80=EC=A7=80 =
&lt;daddyofsky@gmail.com&gt; a =C3=A9crit :</div><br =
class=3D"Apple-interchange-newline"><div><div dir=3D"ltr"><div =
class=3D"gmail-flex gmail-flex-grow gmail-flex-col =
gmail-max-w-full"><div class=3D"gmail-min-h-[20px] gmail-text-message =
gmail-flex gmail-flex-col gmail-items-start gmail-gap-3 =
gmail-whitespace-pre-wrap gmail-break-words =
gmail-[.text-message+&amp;]:mt-5 gmail-overflow-x-auto"><div =
class=3D"gmail-markdown gmail-prose gmail-w-full gmail-break-words =
gmail-dark:prose-invert gmail-light"><p>Hi.</p><p>I would like to =
register an RFC on the following issue.<br><a =
href=3D"https://github.com/php/php-src/issues/13813">https://github.com/ph=
p/php-src/issues/13813</a><br><br>To summarize briefly, users expect =
that the `__callStatic` magic method will be called in all cases when a =
method is not static while using the `__callStatic`. However, in =
reality, if the method is public, the `__callStatic` magic method is not =
called, and an error still occurs.</p><p>I would like to hear your =
opinions.<br><span></span>I also hope someone can help with the RFC =
registration.</p><p><br>--------------------------------------------------=
------<br><br>```php<br>&lt;?php<br>class MyClass<br>{<br>	public =
static function __callStatic($method, $args)<br>	{<br>		=
echo $method . "\n";<br>	}<br><br>	private function =
privateMethod() {}<br>	protected function protectedMethod() {}<br>	=
public function publicMethod() =
{}<br>}<br><br>MyClass::privateMethod();<br>MyClass::protectedMethod();<br=
>MyClass::publicMethod();<br>```<br><br>Resulted in this =
output:<br>```<br>privateMethod<br>protectedMethod<br>Fatal error: =
Uncaught Error: Non-static method MyClass::publicMethod() cannot be =
called statically in ...<br>```<br><br>But I expected this output =
instead:<br>```<br>privateMethod<br>protectedMethod<br>publicMethod<br>```=
</p><p><br></p></div></div></div></div>
</div></blockquote></div><div><br></div>Hi,<div><br></div><div>One of =
the issue is that it is not possible to determine statically that a =
certain call is static or not. It is possible to determine it at =
runtime; but you must be careful to articulate clearly the rules. =
Although it is absolutely possible to have logical rules, I fear that =
they couldn=E2=80=99t be sufficiently simple in order to avoid =
confusion.</div><div><br></div><div>In the following real-world (but =
hopefully rare) case (it is taken from my own codebase), I am calling a =
method of a grandparent class. It is *not* a static =
method:</div><div><br></div><div>```php</div><div><br></div><div>foo =3D =
new class(/* ... */) extends Bar {</div><div><br></div><div>&nbsp; =
&nbsp; // ...</div><div><br></div><div>&nbsp; &nbsp; function Header() =
{</div><div>&nbsp; &nbsp; &nbsp; &nbsp; $grandparent_class =3D =
get_parent_class(parent::class);</div><div>&nbsp; &nbsp; &nbsp; &nbsp; =
$grandparent_class::Header();</div><div>&nbsp; &nbsp; &nbsp; &nbsp;// =
... rest of code</div><div>&nbsp; &nbsp; =
}</div><div><br></div><div>&nbsp; &nbsp;// =
...</div><div>};</div><div>```</div><div><br></div><div>In the following =
more general case, I might intend to call to a static method. However, =
as of today, a call to a non-static method will occur if &nbsp;`A` has a =
non-static accessible method `qux()` *and* `$this` is an instance of =
`A`:</div><div><br></div><div>```php</div><div>class Foo =
{</div><div>&nbsp; &nbsp; function baz() {</div><div>&nbsp; &nbsp; =
&nbsp; &nbsp; A::qux();</div><div>&nbsp; &nbsp; =
}</div><div>}</div><div>```</div><div><br></div><div>(In older versions =
of PHP, a non-static call would occur even when `$this` is not an =
instance of `A`. Hopefully, this is no longer the case since PHP =
8.)</div><div><br></div><div><br></div><div>=E2=80=94Claude</div></body></=
html>=

--Apple-Mail=_83546924-0DDD-49E5-910A-83663045C684--