Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122780
Precedence: bulk
MIME-Version: 1.0
References: <CAAfnsFWRSwWAhps7V0qyso7u_y-tJEQ_-gRm8DOfBS=kUgpy9A@mail.gmail.com>
 <CAPyj-LAAXCs6z1W70O8W-tRxgqCPv0uMyZyyQiwmYEQqkuA2hQ@mail.gmail.com> <CAEKnhAH-26GUtv-0FYCA_3rZ2R8ABRHx-TOrTGRWWOSXyCwiNg@mail.gmail.com>
In-Reply-To: <CAEKnhAH-26GUtv-0FYCA_3rZ2R8ABRHx-TOrTGRWWOSXyCwiNg@mail.gmail.com>
Date: Wed, 27 Mar 2024 17:22:13 +0100
Message-ID: <CAPyj-LAGCLsThGjef7qvjrgOv6dNaujGHvbUfqL01tEEr=U-yA@mail.gmail.com>
Subject: Re: [PHP-DEV] GitHub milestones
To: Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Jakub

On Wed, Mar 27, 2024 at 4:55=E2=80=AFPM Jakub Zelenka <bukka@php.net> wrote=
:
>
> We actually decided not to do it for 8.3 because it would be just waste o=
f time to set all PR's with that milestone. The thing is that PR should jus=
t get merged when it's ready and we won't be delaying release because some =
PR's in that milestone are not ready so it does not have any meaning.

Thank you, I was unaware that this was a conscious decision. I agree
that it's not particularly useful for the next minor version. If they
are ready, nothing is blocking a merge to master.

> I'm not really sure if there's any point to have non-draft PR's targeting=
 next major version because they cannot be merged to master until it is dec=
ided the next version will be the major one. So those PR's should be draft =
but it might make sense to create milestone for them to show quickly why th=
ey are in draft.

Draft PRs that target the next major version can make sense if they
are part of an RFC. I generally believe that every RFC should have at
least a proof-of-concept. In my experience, the implementation is the
only reliable way to reveal conceptual issues.

But then again, such RFCs should be in the RFC listing, as mentioned
in my previous message. So I agree that there's not a big need to
milestones.

> So I don't think there is much point in adding 8.4 milestone but 9.0 migh=
t be useful.

That sounds reasonable to me, as it shouldn't cost much. Milestones
don't need to be complete either, it can be added where it makes
sense, for things that might be forgotten otherwise.

Ilija