Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122777
Precedence: bulk
MIME-Version: 1.0
References: <CAAfnsFWRSwWAhps7V0qyso7u_y-tJEQ_-gRm8DOfBS=kUgpy9A@mail.gmail.com>
In-Reply-To: <CAAfnsFWRSwWAhps7V0qyso7u_y-tJEQ_-gRm8DOfBS=kUgpy9A@mail.gmail.com>
Date: Wed, 27 Mar 2024 16:24:02 +0100
Message-ID: <CAPyj-LAAXCs6z1W70O8W-tRxgqCPv0uMyZyyQiwmYEQqkuA2hQ@mail.gmail.com>
Subject: Re: [PHP-DEV] GitHub milestones
To: Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Peter

On Wed, Mar 27, 2024 at 9:44=E2=80=AFAM Peter Kokot <petk@php.net> wrote:
>
> I was wondering if it would be useful to add GitHub milestones for the PH=
P-8.4 and PHP-9.0 (or PHP-next or something like this)?
> https://github.com/php/php-src/milestones
>
> Because some pull requests might target versions after the PHP-8.4 and it=
 might be useful to have them additionally sorted to not forget about them.=
 Not to tag all PRs of course but only those which are meant to go into som=
e of the future branches.

Milestones have already been used in the past
(https://github.com/php/php-src/milestones?state=3Dclosed), so there's
no reason not to do the same for 8.4 and 9.0. Most likely, we just
forgot. It's probably not documented as part of the release process.

RFCs that have actionable tasks for the next major version should be
listed under "Pending Implementation / Landing" on the RFC page:
https://wiki.php.net/rfc#pending_implementationlanding

Adding them to a GitHub Milestone would make it a bit more explicit.
As for PRs that don't have an RFC, adding them to a milestone
definitely makes sense. However, PRs that may only be merged in the
next major version, and _don't_ require an RFC are extremely rare.

Ilija