Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122775
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Re: [PHP-DEV] [RFC] [Discussion] Support object type in BCMath
In-Reply-To: <904197f4-afb5-401e-9e17-7a655c5449d0@alec.pl>
Date: Wed, 27 Mar 2024 19:46:05 +0900
Cc: php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <E09600E2-9D85-489D-AF27-CA5E0CC9C6DA@sakiot.com>
References: <4F094EDA-5058-407D-AF39-06FD934FDE1F@sakiot.com>
 <bbcff629-4dd6-bc50-ac9f-641849dc218a@php.net>
 <68CF373E-6ABF-4471-8992-813B4BA1B508@sakiot.com>
 <904197f4-afb5-401e-9e17-7a655c5449d0@alec.pl>
To: Aleksander Machniak <alec@alec.pl>
From: saki@sakiot.com (Saki Takamachi)

Hi Aleksander,

> If you write it as:
>=20
> $result =3D $num->withScale(4)->add($num2);
>=20
> it's not an extra line anymore. I also think that withScale() use will =
be rare, as we have the scale in constructor.
>=20
> I think the intention is more clear here, and I think it applies to =
all cases you mentioned, including div or pow. If you know you need to =
change the scale just add ->withScale(X) before.

Ah, that's right. I wonder why I forgot about method chaining. Update =
RFC. If we miss something and $scale is needed, I can always revert the =
RFC.


> I'm not sure I like this. Maybe we should be more strict here and =
treat the $scale in constructor (and later withScale()) as the actual =
scale for all operations.
>=20
> So, in the case above I'd expect ->scale to be 2, and ->value to be =
'2.46'. If I wanted $num to have a scale that may change, I'd not define =
it in the first place. Does that make sense?
>=20
> ps. that also means withScale(null) should be possible.

I see, that may indeed make sense. Now here we have three choices about =
it. In fact, if want to behave like the current RFC, we can do it by =
calculating as `$num + new Number($str)`.
Yeah, I'll fix the RFC for this.

Regards.

Saki=