Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122747
To: <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Support object type in BCMath
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 26 Mar 2024 12:07:51 +0000
In-Reply-To: <5085240B-75B8-40B8-81B9-0E80B80B7C44@sakiot.com>
References: <4F094EDA-5058-407D-AF39-06FD934FDE1F@sakiot.com>
 <38d69258-cdaf-45d3-ba52-dc1398301c8c@redmagic.org.uk>
 <5085240B-75B8-40B8-81B9-0E80B80B7C44@sakiot.com>
Message-ID: <48be5c48dfa8ae2498d185322dd83aa3@gliadin.co.uk>
User-Agent: Roundcube Webmail/0.7.1
From: barney@redmagic.org.uk (Barney Laurance)

On 2024-03-26 11:35, Saki Takamachi wrote:

> **I immediately reflected the above two points in my RFC** :D

Thanks, looks good.

>> One more suggestion - might it be worth adding a `format` function 
>> to the new BcNum class? This would be similar to the existing 
>> number_format function, but would avoid the need to lose precision by 
>> converting to float first.
>
> I came up with the following code, is it close to what you intended?
>
> ```
> $num = BcNum::fromNumberFormat(1.2345, 5);
> $num->value; // 1.23450
> ```

No, that's not quite what I meant - I meant more like the opposite:


```
$bcNum = new BcNum('1234567890123456789.23456789');
echo $bcNum->format(8, '.', ',') // 1,234,567,890,123,456,789.23456789
```


Maybe also worth providing a way to specify that all decimals should be 
printed, instead of just a fixed number of decimals.