Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122746
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Re: [PHP-DEV] [RFC] [Discussion] Support object type in BCMath
In-Reply-To: <38d69258-cdaf-45d3-ba52-dc1398301c8c@redmagic.org.uk>
Date: Tue, 26 Mar 2024 20:35:19 +0900
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <5085240B-75B8-40B8-81B9-0E80B80B7C44@sakiot.com>
References: <4F094EDA-5058-407D-AF39-06FD934FDE1F@sakiot.com>
 <38d69258-cdaf-45d3-ba52-dc1398301c8c@redmagic.org.uk>
To: Barney Laurance <barney@redmagic.org.uk>
From: saki@sakiot.com (Saki Takamachi)

Hi Barney, thanks for the points and suggestions!

> Is there any reason not to give the BcNum class a public readonly =
string `value` property? Would just save a few characters of typing to =
use value instead of getValue().

> Also as with the value, any reason not to make the scale a pubic =
readonly property?

I had completely forgotten about the existence of read-only properties. =
That makes sense.


> I suggest renaming `setScale` to `withScale`. Although the docs will =
make clear that the object is immutable, `set` is associated with =
mutation and might be confusing. `with` is not as well known as a prefix =
but is associated with immutable objects.

Indeed, I felt uncomfortable using "set=E2=80=9D. I didn't know that =
"with" was related to immutable.


**I immediately reflected the above two points in my RFC** :D


> One more suggestion - might it be worth adding a `format` function to =
the new BcNum class? This would be similar to the existing number_format =
function, but would avoid the need to lose precision by converting to =
float first.

I came up with the following code, is it close to what you intended?

```
$num =3D BcNum::fromNumberFormat(1.2345, 5);
$num->value; // 1.23450
```

Regards.

Saki=