Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:122712
Precedence: bulk
MIME-Version: 1.0
References: <fca97d6c-d4ec-4000-958a-72c32beb8421@app.fastmail.com>
 <a715dacb-9bac-4bea-a2bb-c623737fd81e@app.fastmail.com> <ce92f75c-1a59-a469-2a04-6ff391eb2361@php.net>
 <452aae1b-8929-4f08-a388-45b374d2a365@app.fastmail.com> <CAPzBOBMGKQu=3Aj6o20fYM6mKoQzbm2U8s4t34e7jAvjfEYaig@mail.gmail.com>
 <dd3effd7-7a53-42d8-9b00-a232563d8097@app.fastmail.com>
In-Reply-To: <dd3effd7-7a53-42d8-9b00-a232563d8097@app.fastmail.com>
Date: Thu, 21 Mar 2024 17:47:09 +0100
Message-ID: <CAPzBOBOgemRxCzDc1xn0LES+10xRwyWmJHJNNyf-BYt2ErATNA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: landers.robert@gmail.com (Robert Landers)

On Thu, Mar 21, 2024 at 5:15=E2=80=AFPM Larry Garfield <larry@garfieldtech.=
com> wrote:
>
> On Thu, Mar 21, 2024, at 9:10 AM, Robert Landers wrote:
> > Hello,
> >
> > I'm a bit confused on inheritance. In the following example of a
> > proxy, do I need to be aware of a parent's hook and handle it
> > specially?
> >
> > class Loud
> > {
> >     public string $name {
> >         get {
> >             return strtoupper($this->name);
> >         }
> >     }
> > }
> >
> > class LoudProxy extends Loud
> > {
> >    public string $name {
> >        get {
> >            // detected the parent has a hook? //
> >            $return =3D parent::$name::get();
> >            // do something with return //
> >            return $return;
> >        }
> >    }
> > }
> >
> > what happens if the Loud class later removes its hook implementation
> > (ex: moves it to the set hook)? Will my proxy now cause an error?
> >
> > Would simply calling $this->name call the parents hook?
>
> Per the RFC:
>
> "If there is no hook on the parent property, its default get/set behavior=
 will be used. "
>
> so parent::$name::get() will "read the parent property", which will go th=
rough a hook if one is defined, and just read the raw value if not.  So the=
re is no detection logic needed, and the parent can add/remove a hook witho=
ut affecting the child.
>
> Calling $this->name in LoudProxy's get hook will access backing property =
on LoudProxy itself, ignoring the parent entirely.
>
> --Larry Garfield

Awesome! Thanks! I just wasn't sure what "default" meant in this context.

Robert Landers
Software Engineer
Utrecht NL